fix(PE-5263): ignore errors from unknown extension #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit 83bd686): https://arns-portal--pr404-pe-5263-filter-chrom-lbwkg3an.web.app (expires Fri, 26 Jan 2024 21:02:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f59769442cb89cf2a92042a342e51fe94047b94 |
atticusofsparta
changed the title
atticusofsparta
force-pushed
the
PE-5263-filter-chrome-ext-errors
branch
from
70010ff to
ee6d8fb
Compare
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
dtfiedler
reviewed
Jan 12, 2024
src/utils/sentry.ts
Outdated
| return sanitizeEvent(event); | ||
| }, | ||
| }) | ||
| : {}; | ||
|
|
||
| export default sentry; | ||
|
|
||
| const sanitizeEvent = (event: Sentry.Event): Sentry.Event => { | ||
| const filterMessages = new Set([ | ||
| 'chrome-extension://aflkmfhebedbjioipglgcbcmnbpgliof/injected.js', |
There was a problem hiding this comment.
is this the best way to ignore extensions?
There was a problem hiding this comment.
Possibly. I was getting this as the method for ignoring messages, there may be a better way to ignore an actually extension specifically.
There was a problem hiding this comment.
Actually I just realized, with new releases of the extension, this would break. More durable to check for the error message I suppose.
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
atticusofsparta
force-pushed
the
PE-5263-filter-chrome-ext-errors
branch
from
5c43982 to
83bd686
Compare
dtfiedler
approved these changes
Jan 12, 2024
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.