feat(PE-5031): Block network calls when no network and show banner #400
Conversation
…hod access when no network is detected
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit 91fe7ea): https://arns-portal--pr400-pe-5031-no-network-h-1p3xz41r.web.app (expires Thu, 25 Jan 2024 14:33:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f59769442cb89cf2a92042a342e51fe94047b94 |
src/state/actions.ts
Outdated
| warpDataProvider, | ||
| contractCacheProviders, | ||
| ), | ||
| ) as any as ArweaveCompositeDataProvider; |
There was a problem hiding this comment.
I wouldn't do this. Need to review more to offer a suggestion but you're force casting the type of the class to another class.
There was a problem hiding this comment.
can we wrap fetch with an interceptor that checks for connection before sending an HTTP request? Also, not sure you entirely need to go down this route. I agree with the UI showing lack of connection but the way this implemented is not how/where I'd expect. I believe it should be at the HTTP client level.
There was a problem hiding this comment.
removed the service controller wrapper, will just do the UI notification for now.
…ere is no network
atticusofsparta
temporarily deployed
to
develop
GitHub Actions
Inactive
adds service handler wrapper to control method access when no network is detected