-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spotify support #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that some of the packages that you added made it so that it requires the pkg-config
package again. You just need to add it back to the Dockerfile
of the build image.
Tag me back for review when your tasks are completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just need to clear the submitted discussions and then I will approve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, the .enumerate()
/i == 0
changes indeed simplify the code!
Closes #50.
Aims to integrate with already existing code for YouTube playback. Under the hood, it fetches metadata from the Spotify link, builds a relevant query and feeds it to yt-dlp search function.
Tasks
spotify.rs
lazy_static!
and simplifyClientError
initpkg-config
back to the DockerfileScreenshots
Success
Failed to authenticate with Spotify
Failed to fetch track/album/playlist
Failed to fetch private/algorithm playlist