Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: superplay logic #161

Merged
merged 1 commit into from
Feb 24, 2022
Merged

refactor: superplay logic #161

merged 1 commit into from
Feb 24, 2022

Conversation

aquelemiguel
Copy link
Owner

Closes #159.

  • Introduces insert_track method for inserting a track in a specific position of the queue.
  • Removes enqueue_playlist method.
  • When working with playlists, immediately insert each track in the right position instead of rotating in the end.

@aquelemiguel aquelemiguel added 🐛 bug Something isn't working 🧼 refactor Refactors to existing code labels Feb 24, 2022
@afonsojramos
Copy link
Collaborator

Short and to the point, I like it! 🥇

@afonsojramos afonsojramos merged commit def813e into main Feb 24, 2022
@afonsojramos afonsojramos deleted the refactor-superplay-logic branch February 24, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@joao-conde joao-conde Awaiting requested review from joao-conde

Assignees

@aquelemiguel aquelemiguel

@joao-conde joao-conde

@afonsojramos afonsojramos

Labels
🐛 bug Something isn't working 🧼 refactor Refactors to existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/queue live updating should happen after queue manipulation
3 participants
@aquelemiguel @afonsojramos @joao-conde