Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better env loading error message #132

Merged
merged 2 commits into from
Feb 4, 2022
Merged

fix: better env loading error message #132

merged 2 commits into from
Feb 4, 2022

Conversation

afonsojramos
Copy link
Collaborator

Closes #131.

@afonsojramos afonsojramos added the 🐛 bug Something isn't working label Feb 4, 2022
@afonsojramos afonsojramos changed the title fix: better env load error message fix: better env loading error message Feb 4, 2022
@aquelemiguel aquelemiguel merged commit f679a97 into main Feb 4, 2022
@aquelemiguel aquelemiguel deleted the fix-env-error-message branch February 4, 2022 01:40
@joao-conde
Copy link
Collaborator

Already merged, but if anything we should had kept the error propagation up and keep this out of the library code, into the binary: https://github.com/aquelemiguel/parrot/blob/main/src/main.rs#L8-L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquelemiguel aquelemiguel aquelemiguel approved these changes

Assignees

@aquelemiguel aquelemiguel

@joao-conde joao-conde

@afonsojramos afonsojramos

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DISCORD_APPID to docs + Better error message for missing env variables
3 participants
@afonsojramos @joao-conde @aquelemiguel