ci: split save and restore cache actions
#7614
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,80 @@ | ||||||
| name: Cache test images | ||||||
| on: | ||||||
| workflow_dispatch: | ||||||
|
|
||||||
| env: | ||||||
| GO_VERSION: '1.22' | ||||||
| jobs: | ||||||
| test-images: | ||||||
| name: Cache test images | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Check out code into the Go module directory | ||||||
| uses: actions/checkout@v4.1.6 | ||||||
|
|
||||||
| - name: Set up Go | ||||||
| uses: actions/setup-go@v5 | ||||||
| with: | ||||||
| go-version: ${{ env.GO_VERSION }} | ||||||
|
There was a problem hiding this comment. We use
Suggested change
There was a problem hiding this comment. I also thought about this. |
||||||
|
|
||||||
| - name: Install tools | ||||||
| uses: aquaproj/aqua-installer@v3.0.1 | ||||||
| with: | ||||||
| aqua_version: v1.25.0 | ||||||
|
|
||||||
| - name: Download test images | ||||||
|
There was a problem hiding this comment. Should restore cache before this step. Otherwise, it downloads images every time. There was a problem hiding this comment. Done 91a8016 We use |
||||||
| if: github.ref == 'refs/heads/main' | ||||||
| run: mage test:fixtureContainerImages | ||||||
|
|
||||||
| - name: Generate image list digest | ||||||
| if: github.ref == 'refs/heads/main' | ||||||
|
There was a problem hiding this comment. nit
Suggested change
|
||||||
| id: image-digest | ||||||
| run: | | ||||||
| IMAGE_LIST=$(skopeo list-tags docker://ghcr.io/aquasecurity/trivy-test-images) | ||||||
| DIGEST=$(echo "$IMAGE_LIST" | sha256sum | cut -d' ' -f1) | ||||||
| echo "digest=$DIGEST" >> $GITHUB_OUTPUT | ||||||
|
|
||||||
| ## We need to save test image cache only for main branch | ||||||
| - name: Save test images into cache | ||||||
| if: github.ref == 'refs/heads/main' | ||||||
| uses: actions/cache/save@v4 | ||||||
| with: | ||||||
| path: integration/testdata/fixtures/images | ||||||
| key: cache-test-images-${{ steps.image-digest.outputs.digest }} | ||||||
|
|
||||||
| test-vm-images: | ||||||
| name: Cache test VM images | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Check out code into the Go module directory | ||||||
| uses: actions/checkout@v4.1.6 | ||||||
|
|
||||||
| - name: Set up Go | ||||||
| uses: actions/setup-go@v5 | ||||||
| with: | ||||||
| go-version: ${{ env.GO_VERSION }} | ||||||
|
|
||||||
| - name: Install tools | ||||||
| uses: aquaproj/aqua-installer@v3.0.1 | ||||||
| with: | ||||||
| aqua_version: v1.25.0 | ||||||
|
|
||||||
| - name: Download test VM images | ||||||
| if: github.ref == 'refs/heads/main' | ||||||
| run: mage test:fixtureVMImages | ||||||
|
|
||||||
| - name: Generate image list digest | ||||||
| if: github.ref == 'refs/heads/main' | ||||||
| id: image-digest | ||||||
| run: | | ||||||
| IMAGE_LIST=$(skopeo list-tags docker://ghcr.io/aquasecurity/trivy-test-vm-images) | ||||||
| DIGEST=$(echo "$IMAGE_LIST" | sha256sum | cut -d' ' -f1) | ||||||
| echo "digest=$DIGEST" >> $GITHUB_OUTPUT | ||||||
|
|
||||||
| ## We need to save test VM image cache only for main branch | ||||||
| - name: Save test VM images into cache | ||||||
| if: github.ref == 'refs/heads/main' | ||||||
| uses: actions/cache/save@v4 | ||||||
| with: | ||||||
| path: integration/testdata/fixtures/vm-images | ||||||
| key: cache-test-vm-images-${{ steps.image-digest.outputs.digest }} | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to add
schedule.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do this job once a day?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's start with daily. Most images are unchanged, and we don't call GHCR API other than listing tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 91a8016