fix: check gcr service account #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vadimceb
changed the title
chen-keinan
approved these changes
Jul 28, 2024
|
@vadimceb please sign the CLA |
@chen-keinan thanks for the replay and review! I've updated the email to match the one in github. Should be fine now 🙏 |
This address the pull requested merged aquasecurity#2108. but the check was getting the default value where the propery was missing
vadimceb
force-pushed
the
fix-gcr-serviceaccount-check
branch
from
d641e9e to
b252651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the checks for the gcr service account/
Description
This address the pull requested #2108 merged.
KeyScanJobUseGCRServiceAccount.Related issues