Bump lint tools versions #4616
Open
Bump lint tools versions #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This unblocks #4615 |
NDStrahilevitz
approved these changes
Feb 23, 2025
| @@ -1,5 +1,4 @@ | |||
| //go:build arm64 | |||
| // +build arm64 | |||
There was a problem hiding this comment.
I don't think we have syscall tests in the e2es. We do have them in integration, but integration only runs in amd64. I understand that revive considers this redundant but this is a sensitive change.
So I think we should:
- Test syscalls manually in this PR in an arm64 machine
- Add a mirror integration test job that runs on an arm64 runner. I have opened Mirror integration tests on ARM64 #4621 for this.
| @@ -23,25 +23,25 @@ enableAllRules = true | |||
| [rule.call-to-gc] | |||
| Disabled = false | |||
| [rule.confusing-naming] | |||
| Disabled = true | |||
| Disabled = true # TODO: consider enabling this | |||
| [rule.comment-spacings] | |||
| Disabled = false | |||
| [rule.confusing-results] | |||
There was a problem hiding this comment.
You've disabled this in containerd.go , near where I am refactoring this right now. It would be useful to know what this option entails so I can tackle it at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
fd50c23 chore(lint): bump errcheck to 1.9.0
57bf903 chore(lint): bump staticcheck to 2025.1
368273c chore(lint): consider to enable revive rules
2a5419f chore(lint): apply revive modifies-value-receiver rule
2dfc114 chore(lint): apply revive control-nesting rule
d0d95d2 chore(lint): apply revive redundant-build-tag rule
f788752 chore(lint): apply revive superfluous-else rule
a08433f chore(lint): apply revive use-errors-new rule
2dda968 chore(lint): bump revive to 1.7.0
2. Explain how to test it
3. Other comments