feat: Workaround missing tfsec release assets #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
owenrumney
reviewed
Mar 23, 2022
entrypoint.sh
Outdated
| fi | ||
|
|
||
| wget -O - -q "$(wget -q https://api.github.com/repos/aquasecurity/tfsec/releases/${TFSEC_VERSION} -O - | grep -o -E "https://.+?tfsec-linux-amd64" | head -n1)" > tfsec-linux-amd64 | ||
| wget -O - -q "$(wget -q https://api.github.com/repos/aquasecurity/tfsec/releases/${TFSEC_VERSION} -O - | grep -o -E "https://.+?tfsec_checksums.txt" | head -n1)" > tfsec.checksums | ||
| wget -O - -q "$(wget -q https://api.github.com/repos/aquasecurity/tfsec/releases -O - | grep -m 1 -o -E "https://.+?tfsec-linux-amd64" | head -n1)" > tfsec-linux-amd64 |
There was a problem hiding this comment.
I don't see how this will work when the user specifies a specific version of tfsec to use.
There was a problem hiding this comment.
Oh, yeah - I meant to just drop the /, not the whole thing.
If a tfsec release exists, but has no assets, this workflow breaks if it's set/defaults to latest. https://github.com/aquasecurity/tfsec/issues/1618 Workaround by using the most recent version that has a correctly matching asset.
aidy
force-pushed
the
fix_missing_latest
branch
from
cf83da3 to
aea502e
Compare
owenrumney
approved these changes
Mar 24, 2022
owenrumney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tfsec release exists, but has no assets, this workflow breaks if
it's set/defaults to latest.
https://github.com/aquasecurity/tfsec/issues/1618
Workaround by using the most recent version that has a correctly
matching asset.