Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

unknown method PrintTabs for service dashboard.Plugin #80

Closed
lechugaletal opened this issue Apr 13, 2021 · 2 comments · Fixed by #81
Closed

unknown method PrintTabs for service dashboard.Plugin #80

lechugaletal opened this issue Apr 13, 2021 · 2 comments · Fixed by #81
Assignees

Comments

@lechugaletal
Copy link

Hi,

starboard v0.9.2 + starboard-octant-plugin v0.9.2 is not working with octant v0.19.0 / v0.18.0

Plugin Error

getting tabs from plugins: handle object: running on starboard-octant-plugin: printing tabResponse for plugin "starboard-octant-plugin": grpc client print tab: rpc error: code = Unimplemented desc = unknown method PrintTabs for service dashboard.Plugin

No problem with octant v0.16.3.

Any idea would be appreciated.

Thanks.

@danielpacak
Copy link
Contributor

danielpacak commented Apr 13, 2021

👋 @lechugaletal Thank you for reporting this issue. We're aware of that. Octant 0.18+ introduced a non backward compatible change in Go Plugins API in order to support a nice feature of registering multiple tabs for a given GVK. To fix that we have to bump up Octant dependency in go.mod. We're going to do that along with the upcoming release of Starboard v0.10.0

@danielpacak danielpacak self-assigned this Apr 13, 2021
danielpacak added a commit that referenced this issue Apr 14, 2021
Resolves: #80

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak added a commit that referenced this issue Apr 14, 2021
Resolves: #80

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak added a commit that referenced this issue Apr 15, 2021
Resolves: #80

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@jisnardo
Copy link

Great job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants