Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CIS-1.9 policies 5.1.1/5.1.5 typos #1658

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

andypitcher
Copy link
Contributor

This PR fixes a typo in CIS-1.9 policies 5.1.1 check. The typo resides in the last part of the audit, where the role_binding isn't printed out.

The modification: ${rolebinding} is turned into ${role_binding}.

Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@mozillazg mozillazg requested a review from chen-keinan August 6, 2024 13:32
@andypitcher andypitcher changed the title Fix CIS-1.9 policies 5.1.1 typo Fix CIS-1.9 policies 5.1.1/5.1.5 typos Aug 21, 2024
@andypitcher
Copy link
Contributor Author

@afdesk @mozillazg I've rebased this PR too.

@mozillazg mozillazg requested review from afdesk and removed request for chen-keinan September 28, 2024 07:26
Copy link
Collaborator

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the contribution!

@afdesk afdesk merged commit b85ec78 into aquasecurity:main Sep 30, 2024
5 checks passed
deebhatia pushed a commit to VoerEirAB/kube-bench that referenced this pull request Oct 14, 2024
* Fix CIS-1.9 policies 5.1.1 typo

* Fix typo CIS-1.9 5.1.5

* Add new lines to CIS-1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants