Wip/tools merge #331
Merged
Wip/tools merge #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Podman/Docker can now be specified as source for the s3gw container image when building the cluster. - Updated README.md Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
- Fix various typos. - Add s3gw secret to be able to backup a Longhorn volume to S3. Signed-off-by: Volker Theile <vtheile@suse.com>
- Initial feature complete - Updated README.md Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
- User can override --rgw-backend-store and --debug-rgw arguments. They default respectively with values: dbstore, 1. Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
- added configMap for s3gw deployment Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
default arguments for s3gw container
- Adjusted NGINX ingress configuration for s3gw deployment Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
K8s on vms for s3gw container
- Added the ability to choose if allocate a disk for admin/worker on k8s cluster - Set client_max_body_size to 0 for s3gw's ingress on k8s Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
- Added start command in s3gwctl in k8s Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
Signed-off-by: Jesus Herman-Marina <jherman@suse.com>
Signed-off-by: Jesus Herman jherman@suse.com Signed-off-by: Jesus Herman-Marina <jherman@suse.com>
Move build/readme to main README
- Search for local s3gw image and use it by default. - Add '--s3gw-image' option to define a different s3gw image. Defaults to 'ghcr.io/aquarist-labs/s3gw:latest'. New behaviour: Look for local s3gw image. If it exists, then import that into k3s, otherwise pull it from ghcr.io. Signed-off-by: Volker Theile <vtheile@suse.com>
Currently, the build-radosgw container has a minimal set of packages necessary for the build, then later when you *run* the container, it calls out to `install-deps.sh` from the ceph source tree to install ceph's build dependencies (300+ rpms). This takes about 15 minutes (for me, at least, with my rural Tasmanian internet connection), and happens every time I run the build-radosgw container to build ceph. If we put all these dependencies inside Dockerfile.build-radosgw instead, they only get downloaded once, when building that container. We still run `install-deps.sh` in case any new dependencies have been added to ceph in the meantime, but at least we'll have almost all of them upfront. Signed-off-by: Tim Serong <tserong@suse.com>
- Use Dockerfile for podman and docker to reduce duplicate code. - Add missing options in Dockerfile. Signed-off-by: Volker Theile <vtheile@suse.com>
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
- Added no-tls ingress for s3gw Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
Uses an s3gw-dev.yaml spec file to ensure we use local images instead of pulling from github's container registry. Signed-off-by: Joao Eduardo Luis <joao@suse.com>
k3s: setup UX improvements
- k8s stable upgraded to 1.24.0 from 1.23.x line; with this release Docker support has been removed. Due to this, project playbooks have been updated in order to configure containerd as CRI interface for k8s. - Added some options when building the environment. A notable option is that now you can choose the s3gw image to use in the deployment. - Some cleaning Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
This _massively_ speeds up builds (after the first one, at least). Signed-off-by: Tim Serong <tserong@suse.com>
…will be separated by different ports. References: s3gw-tech/s3gw-charts#57 Signed-off-by: Volker Theile <vtheile@suse.com>
Added a script able to update the s3gw's deployment in Kubernetes
Signed-off-by: Volker Theile <vtheile@suse.com>
Adds 2 new unit tests added to rgw after merging the following PRs: aquarist-labs/ceph#59 aquarist-labs/ceph#56 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
tools: add new rgw/sfs unit tests
There was an error introduced in PR: aquarist-labs/s3gw-tools#192 This removes the extra quotes added in the Dockerfile Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
tools: Fix test container Dockerfile
Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
Merge w v0.9.0
- remove code duplication - disable jaegertracing (we don't use it at the moment) - more advanced logic to deal with git safe directories - inherit build options from environment and print out the complete set of build options set in the script - fix linter warnings from shellcheck - make linter run all pre-commit linting actions - make markdownlint not complain about multiple headings with the same name unless they are under the same heading themselves Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
build: rework build script
- Fix reading markdownlint configuration - Fix build process by going back to Ninja instead of GnuMake, since the Makefiles generated by CMake seem bugged with random compile errors on first run and inconsistent targets Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
ci: fix build-radosgw script and linter
This commit goes in conjunction with aquarist-labs/ceph#68 In order to make ceph repo independant from s3gw-tools and be able to run the unittests and other tests the build script has been moved to the ceph repository. The new script also offer the possibility to set a user defined build script (via the new env variable BUILD_SCRIPT) in case we have special needs for particular tests or to extend the ci on the ceph repository. If, for example, we need to add a new flag when building the gateway, or a new test it will be done in the ceph repository and the change will be tested in its own ci in the same pull request. This way the build container remains the same being just a holder of the needed environment, but the how we build the gateways is ruled by the ceph repository. This also moves the tests to the ceph repository, so we can also run them in any ceph's PR without depending on s3gw-tools. It also creates 2 new containers for running the `radosgw` and its unit tests in the `ceph` repo CI. Those containers are mere base for running those processes and the binaries and libraries are mounted. That way we don't need to fully create a container with the binaries and we can reuse them. Fixes: https://github.com/aquarist-labs/s3gw/issues/127 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
tools: change build-radosgw.sh to use ceph's repo script
- Fix broken links in badges - Add more informative description - Remove duplicate config for markdownlint - Change description to match the repos purpose as it is no longer the main repo of the project Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
docs: fixup readme
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
build: add missing 'libcap-devel' to radosgw build
We are no longer building libradosgw.so, and it seems the radosgw binary is statically linking librgw_a.a instead. Signed-off-by: Joao Eduardo Luis <joao@suse.com>
build: drop libradosgw libs from s3gw container
Preparations to merge tools repository into s3gw repository. These preparations move all contents of the s3gw-tools repository into place, so it can be merged into the s3gw repository without losing git history. It also removes file conflicts with the other repository. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
preparations to merge tools repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the merge of the tools repo, including all it's git history