Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add depth to chart #338

Merged
merged 14 commits into from
Oct 26, 2020
Merged

Add depth to chart #338

merged 14 commits into from
Oct 26, 2020

Conversation

Ry-DS
Copy link
Collaborator

@Ry-DS Ry-DS commented Oct 23, 2020 •
edited by ericboucher
Loading

Closes #187
QOL:

  • Added chart.js types
  • Made React extend eslint config, ignored currently outstanding eslint issues.
  • Reduced duplication

Screen Shot 2020-10-24 at 6 45 14 PM

@Ry-DS Ry-DS marked this pull request as ready for review October 24, 2020 08:00
@Ry-DS Ry-DS requested a review from ericboucher October 24, 2020 08:00
@Ry-DS Ry-DS requested a review from ericboucher October 24, 2020 08:50
@ericboucher
Copy link
Member

Looks great, is there any way to move the survey points to the bottom temp when possible?

See #287

@Ry-DS
Copy link
Collaborator Author

Ry-DS commented Oct 25, 2020 •
edited
Loading

@ericboucher Think it should do that now, make sure to test with prod - dev doesn't have any survey points taken when bottom temps data is introduced.

Also, any idea why the build is failing?

@Ry-DS
Copy link
Collaborator Author

Ry-DS commented Oct 25, 2020 •
edited
Loading

facebook/create-react-app#8320
^ an ongoing issue with CRA is why current build is failing. Something to do with code splitting and memory. I'll try edit the last commit to fix this

ericboucher
ericboucher approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@ericboucher ericboucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's investigate the tooltip reactivity a little but it looks great otherwise, nice work!

@ericboucher ericboucher merged commit c171231 into master Oct 26, 2020
@ericboucher ericboucher deleted the add-depth-chart branch October 26, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericboucher ericboucher ericboucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Ry-DS @ericboucher