Add API to get module event #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @returns Promise<GetEventsResponse> | ||
| */ | ||
| async getModuleEventsByEventType(args: { | ||
| eventType: MoveStructId; |
There was a problem hiding this comment.
Can you add a check here that if the event type is too long (wrapped for example) we should send a warning and possibly error. We cap indexed_event at length 300.
There was a problem hiding this comment.
Added to internal function below
0xmaayan
approved these changes
Feb 23, 2024
0xaptosj
force-pushed
the
j/add-module-event-api
branch
from
54e589b to
6514bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new event API to get module event from indexer.
Test Plan
Uint test.
Related Links
aptos-labs/aptos-developer-discussions#6