Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uniform comments in aptos-crypto/src/traits.rs #9733

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

alinush
Copy link
Contributor

@alinush alinush commented Aug 23, 2023

Description

cc @zjma, @danielxiangzl

@alinush alinush enabled auto-merge (squash) August 23, 2023 18:28
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> d0c649ceacead68a5b560876b2a8bca82b74e678

Compatibility test results for aptos-node-v1.6.2 ==> d0c649ceacead68a5b560876b2a8bca82b74e678 (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 3957 txn/s, latency: 7723 ms, (p50: 7700 ms, p90: 11100 ms, p99: 13600 ms), latency samples: 162240
2. Upgrading first Validator to new version: d0c649ceacead68a5b560876b2a8bca82b74e678
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1775 txn/s, latency: 16183 ms, (p50: 18800 ms, p90: 22300 ms, p99: 22500 ms), latency samples: 92300
3. Upgrading rest of first batch to new version: d0c649ceacead68a5b560876b2a8bca82b74e678
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1844 txn/s, latency: 15603 ms, (p50: 18800 ms, p90: 22000 ms, p99: 22400 ms), latency samples: 92200
4. upgrading second batch to new version: d0c649ceacead68a5b560876b2a8bca82b74e678
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3345 txn/s, latency: 9483 ms, (p50: 9600 ms, p90: 13500 ms, p99: 13900 ms), latency samples: 143860
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> d0c649ceacead68a5b560876b2a8bca82b74e678 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d0c649ceacead68a5b560876b2a8bca82b74e678

two traffics test: inner traffic : committed: 6208 txn/s, latency: 6310 ms, (p50: 5900 ms, p90: 8100 ms, p99: 14100 ms), latency samples: 2688380
two traffics test : committed: 100 txn/s, latency: 3052 ms, (p50: 2900 ms, p90: 3700 ms, p99: 6600 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.213", "QsPosToProposal: max: 0.334, avg: 0.179", "ConsensusProposalToOrdered: max: 0.637, avg: 0.601", "ConsensusOrderedToCommit: max: 0.564, avg: 0.529", "ConsensusProposalToCommit: max: 1.152, avg: 1.130"]
Max round gap was 1 [limit 4] at version 1323724. Max no progress secs was 3.701962 [limit 10] at version 1323724.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> d0c649ceacead68a5b560876b2a8bca82b74e678

Compatibility test results for aptos-node-v1.5.1 ==> d0c649ceacead68a5b560876b2a8bca82b74e678 (PR)
Upgrade the nodes to version: d0c649ceacead68a5b560876b2a8bca82b74e678
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 3050 txn/s, latency: 7178 ms, (p50: 7500 ms, p90: 9600 ms, p99: 13800 ms), latency samples: 167760
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> d0c649ceacead68a5b560876b2a8bca82b74e678 passed
Test Ok

@alinush alinush merged commit c222eb5 into main Aug 23, 2023
71 of 73 checks passed
@alinush alinush deleted the alin/fix-uniform-trait-comments branch August 23, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants