[dag][bugfix] fix bitmask for incomplete first round

[ibalajiarun]

Description

This PR fixes the bitmask fn in the dag_store to make it return the proper bitmask when starting from an empty DAG. Previously, it was only properly handling the case when the initial round of the DAG store is 0, which doesn't accommodate for when starting a DAG store without the whole prefix.

Test Plan

Fixed unit tests.

[ibalajiarun]

Current dependencies on/for this PR:

• main
  • PR [dag] Handle certified node in DAG Driver #9312
    • PR [dag] Integrate Order Rule with dag driver #9452
      • PR [dag] Integrate Dag Fetcher with Dag Driver #9453
        • PR [dag] rename reliable_broadcast.rs to rb_handler.rs #9454
          • PR [dag] bootstrap logic #9455
            • PR [dag] network sender implementation #9456
              • PR [dag] e2e integration test #9457
                • PR [dag] Integrate dag fetcher with RB node handler #9585
                  • PR [dag][bugfix] fix bitmask for incomplete first round #9723 👈
                  • PR [dag] preliminary state sync implementation #9724

This comment was auto-generated by Graphite.

[sasha8]

nit: if the DAG is empty you return Some(lowest_round), but if the DAG is full you return None. The question is why empty DAG is not considered full. In the sense that all rounds either have all nodes or none?

[ibalajiarun]

Good point, removed the option and now I return the actual round that is incomplete. For a full dag, its highest_round+1, and an empty dag, its lowest_round.

[github-actions]

✅ Forge suite compat success on aptos-node-v1.6.2 ==> bc4d9ee513b62632f1eff27be89371d652118531

Compatibility test results for aptos-node-v1.6.2 ==> bc4d9ee513b62632f1eff27be89371d652118531 (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4642 txn/s, latency: 6826 ms, (p50: 6600 ms, p90: 9900 ms, p99: 12600 ms), latency samples: 190360
2. Upgrading first Validator to new version: bc4d9ee513b62632f1eff27be89371d652118531
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1788 txn/s, latency: 16293 ms, (p50: 18700 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 93000
3. Upgrading rest of first batch to new version: bc4d9ee513b62632f1eff27be89371d652118531
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1856 txn/s, latency: 15569 ms, (p50: 18700 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92820
4. upgrading second batch to new version: bc4d9ee513b62632f1eff27be89371d652118531
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3364 txn/s, latency: 9447 ms, (p50: 10000 ms, p90: 12900 ms, p99: 13200 ms), latency samples: 141320
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> bc4d9ee513b62632f1eff27be89371d652118531 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on bc4d9ee513b62632f1eff27be89371d652118531

two traffics test: inner traffic : committed: 6127 txn/s, latency: 6388 ms, (p50: 6000 ms, p90: 8100 ms, p99: 11700 ms), latency samples: 2659140
two traffics test : committed: 100 txn/s, latency: 3193 ms, (p50: 3000 ms, p90: 3700 ms, p99: 6900 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.263, avg: 0.216", "QsPosToProposal: max: 0.189, avg: 0.161", "ConsensusProposalToOrdered: max: 0.686, avg: 0.628", "ConsensusOrderedToCommit: max: 0.510, avg: 0.489", "ConsensusProposalToCommit: max: 1.155, avg: 1.116"]
Max round gap was 1 [limit 4] at version 37704. Max no progress secs was 3.678299 [limit 10] at version 1216385.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> bc4d9ee513b62632f1eff27be89371d652118531

Compatibility test results for aptos-node-v1.5.1 ==> bc4d9ee513b62632f1eff27be89371d652118531 (PR)
Upgrade the nodes to version: bc4d9ee513b62632f1eff27be89371d652118531
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4621 txn/s, latency: 7210 ms, (p50: 7800 ms, p90: 10200 ms, p99: 10800 ms), latency samples: 166360
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> bc4d9ee513b62632f1eff27be89371d652118531 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking