Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StateValueMetadata and reenable metadata tracking on devnet #9480

Merged
merged 3 commits into from
Aug 13, 2023
Merged

Update StateValueMetadata and reenable metadata tracking on devnet #9480

merged 3 commits into from
Aug 13, 2023

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Aug 3, 2023 •
edited
Loading

Description

  1. stop tracking the payer
  2. implement deposit tracking (the slot fee)
  3. enable tracking on devnet

Implementing the refund next

Test Plan

  1. test_metadata_tracking() updated
  2. replay-verify https://github.com/aptos-labs/aptos-core/actions/runs/5799529398

msmouse
msmouse commented Aug 7, 2023
View reviewed changes
aptos-move/e2e-testsuite/Cargo.toml Outdated
@@ -19,7 +19,7 @@ aptos-crypto = { workspace = true }
aptos-framework = { workspace = true }
aptos-gas-algebra = { workspace = true }
aptos-gas-meter = { workspace = true }
aptos-gas-schedule = { workspace = true }
aptos-gas-schedule = { workspace = true, features = ["testing"] }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes this issue #9501 (comment)

@msmouse msmouse changed the title remove payer from StateValueMetadata Update StateValueMetadata and reenable metadata tracking on devnet Aug 7, 2023
@msmouse msmouse marked this pull request as ready for review August 8, 2023 03:15
@msmouse msmouse requested a review from a team August 8, 2023 03:16
@msmouse msmouse requested a review from vgao1996 August 9, 2023 20:42
@msmouse msmouse mentioned this pull request Aug 9, 2023
Merged
zekun000
zekun000 approved these changes Aug 10, 2023
View reviewed changes
types/src/state_store/state_value.rs
deposit: u64,
creation_time_usecs: &CurrentTimeMicroseconds,
) -> Self {
pub fn new(deposit: u64, creation_time_usecs: &CurrentTimeMicroseconds) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this thing is never used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, only on devnet, never on testnet or mainnet.

@msmouse msmouse enabled auto-merge (rebase) August 10, 2023 21:21
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@msmouse msmouse requested review from a team as code owners August 13, 2023 19:23
@msmouse msmouse disabled auto-merge August 13, 2023 19:25
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@msmouse msmouse enabled auto-merge (rebase) August 13, 2023 23:02
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 29b1fc659e4d6831ccaf7d86886d5194b43fef7e

Compatibility test results for aptos-node-v1.6.2 ==> 29b1fc659e4d6831ccaf7d86886d5194b43fef7e (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4204 txn/s, latency: 7273 ms, (p50: 6000 ms, p90: 10100 ms, p99: 27800 ms), latency samples: 185000
2. Upgrading first Validator to new version: 29b1fc659e4d6831ccaf7d86886d5194b43fef7e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1803 txn/s, latency: 16146 ms, (p50: 18900 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 93780
3. Upgrading rest of first batch to new version: 29b1fc659e4d6831ccaf7d86886d5194b43fef7e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1764 txn/s, latency: 15122 ms, (p50: 17700 ms, p90: 21200 ms, p99: 22300 ms), latency samples: 91760
4. upgrading second batch to new version: 29b1fc659e4d6831ccaf7d86886d5194b43fef7e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3186 txn/s, latency: 9325 ms, (p50: 10000 ms, p90: 12600 ms, p99: 13300 ms), latency samples: 137020
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 29b1fc659e4d6831ccaf7d86886d5194b43fef7e passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 29b1fc659e4d6831ccaf7d86886d5194b43fef7e

two traffics test: inner traffic : committed: 6538 txn/s, latency: 6005 ms, (p50: 5700 ms, p90: 7800 ms, p99: 11100 ms), latency samples: 2824660
two traffics test : committed: 100 txn/s, latency: 3266 ms, (p50: 3100 ms, p90: 3900 ms, p99: 8100 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.212", "QsPosToProposal: max: 0.312, avg: 0.161", "ConsensusProposalToOrdered: max: 0.601, avg: 0.553", "ConsensusOrderedToCommit: max: 0.544, avg: 0.519", "ConsensusProposalToCommit: max: 1.108, avg: 1.072"]
Max round gap was 1 [limit 4] at version 10053. Max no progress secs was 3.8386059 [limit 10] at version 1363926.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 29b1fc659e4d6831ccaf7d86886d5194b43fef7e

Compatibility test results for aptos-node-v1.5.1 ==> 29b1fc659e4d6831ccaf7d86886d5194b43fef7e (PR)
Upgrade the nodes to version: 29b1fc659e4d6831ccaf7d86886d5194b43fef7e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4730 txn/s, latency: 7058 ms, (p50: 7500 ms, p90: 10000 ms, p99: 10500 ms), latency samples: 170300
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 29b1fc659e4d6831ccaf7d86886d5194b43fef7e passed
Test Ok

@msmouse msmouse merged commit c54916a into aptos-labs:main Aug 13, 2023
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grao1991 grao1991 grao1991 approved these changes

@zekun000 zekun000 zekun000 approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msmouse @grao1991 @zekun000