Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts-sdk] Fix output errors of publish ANS contract script #7926

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

gregnazario
Copy link
Contributor

Description

The previous runs failed because they didn't parse the output errors correctly in the event there was no stdout / stderr.

 console.error("parsed stdout", error.stdout.toString("utf8"));

Test Plan

Tested manually with

export APTOS_NODE_URL=http://127.0.0.1:8080/v1
export APTOS_FAUCET_URL=http://127.0.0.1:8081
pnpm test

@gregnazario gregnazario enabled auto-merge (squash) April 26, 2023 01:51
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7594 TPS, 5038 ms latency, 7400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8
compatibility::simple-validator-upgrade::single-validator-upgrade : 4733 TPS, 8853 ms latency, 11800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8
compatibility::simple-validator-upgrade::half-validator-upgrade : 4358 TPS, 9250 ms latency, 11700 ms p99 latency,no expired txns
4. upgrading second batch to new version: 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6162 TPS, 6393 ms latency, 9700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8

performance benchmark : 5134 TPS, 7732 ms latency, 26400 ms p99 latency,(!) expired 506 out of 2192740 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8 (PR)
Upgrade the nodes to version: 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8
framework_upgrade::framework-upgrade::full-framework-upgrade : 5434 TPS, 7414 ms latency, 10500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 34cb6ce562bd2a4004c0100b1b1bf31515f68fd8 passed
Test Ok

Copy link
Contributor

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@gregnazario gregnazario merged commit 36c557a into main Apr 26, 2023
@gregnazario gregnazario deleted the fix-ts-sdk-tests branch April 26, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants