Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Update spec of create_resource_account() #6227

Merged
merged 2 commits into from
Jan 20, 2023
Merged

[Spec] Update spec of create_resource_account() #6227

merged 2 commits into from
Jan 20, 2023

Conversation

xudon9
Copy link
Contributor

@xudon9 xudon9 commented Jan 18, 2023 •
edited
Loading

Description

This is a part of spec work for Aptos Framework from MoveBit,. The change in this PR is:

  • Specified the behavior of create_resource_account() with the help of a spec function and conditional included schemas.

Test Plan

Using command move prove -t account.move

junkil-park
junkil-park approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@junkil-park junkil-park left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec looks good to me. Can you re-run the document generator so that .md files become up-to-date?

@junkil-park junkil-park enabled auto-merge (squash) January 20, 2023 01:32
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 4c5f7849728c42d632426898d8ccd33893290600

performance benchmark with full nodes : 6110 TPS, 6501 ms latency, 11700 ms p99 latency,(!) expired 300 out of 2609440 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4c5f7849728c42d632426898d8ccd33893290600

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4c5f7849728c42d632426898d8ccd33893290600 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7422 TPS, 5185 ms latency, 7300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 4c5f7849728c42d632426898d8ccd33893290600
compatibility::simple-validator-upgrade::single-validator-upgrade : 4398 TPS, 9050 ms latency, 13300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 4c5f7849728c42d632426898d8ccd33893290600
compatibility::simple-validator-upgrade::half-validator-upgrade : 4604 TPS, 9075 ms latency, 12000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 4c5f7849728c42d632426898d8ccd33893290600
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6546 TPS, 5975 ms latency, 10800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4c5f7849728c42d632426898d8ccd33893290600 passed
Test Ok

@junkil-park junkil-park merged commit 283cedc into aptos-labs:main Jan 20, 2023
@qpb8023 qpb8023 deleted the movebit_account branch February 13, 2023 01:32
@Abuchtela Abuchtela mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkil-park junkil-park junkil-park approved these changes

@movekevin movekevin movekevin approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@rahxephon89 rahxephon89 Awaiting requested review from rahxephon89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xudon9 @junkil-park @movekevin @qpb8023