Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crates] Rename crates E through H inclusive #5824

Merged
merged 1 commit into from
Dec 8, 2022
Merged

[crates] Rename crates E through H inclusive #5824

merged 1 commit into from
Dec 8, 2022

Conversation

banool
Copy link
Contributor

@banool banool commented Dec 8, 2022 •
edited
Loading

Description

Continuing the work to rename everything to aptos-<name>.

For future me, things like this were handy:

rg 'use executor_types::' --type rust -l | xargs sd 'use executor_types::' 'use aptos_executor_types::'

Test Plan

scripts/rust_lint.sh locally. Then CI.

@banool banool force-pushed the banool/crates_e_to_h branch from ffedc57 to 795b173 Compare December 8, 2022 12:14
@banool banool added CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:run-coverage run tests with test coverage instrumentation labels Dec 8, 2022
@banool banool force-pushed the banool/crates_e_to_h branch 3 times, most recently from 0f67e10 to 0728c53 Compare December 8, 2022 13:12
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@banool banool marked this pull request as ready for review December 8, 2022 13:44
JoshLind
JoshLind approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@JoshLind JoshLind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @banool! Looks reasonable to me :D

@github-actions

This comment has been minimized.

Sign in to view
@banool banool enabled auto-merge (squash) December 8, 2022 14:01
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

✅ Forge suite land_blocking success on 0728c53525aba63abf573d4f18edd501035c0475

performance benchmark with full nodes : 6863 TPS, 5782 ms latency, 8700 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0728c53525aba63abf573d4f18edd501035c0475

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0728c53525aba63abf573d4f18edd501035c0475 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7220 TPS, 5383 ms latency, 7900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 0728c53525aba63abf573d4f18edd501035c0475
compatibility::simple-validator-upgrade::single-validator-upgrade : 4731 TPS, 8465 ms latency, 12600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 0728c53525aba63abf573d4f18edd501035c0475
compatibility::simple-validator-upgrade::half-validator-upgrade : 4810 TPS, 8494 ms latency, 11100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 0728c53525aba63abf573d4f18edd501035c0475
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6419 TPS, 5955 ms latency, 10900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0728c53525aba63abf573d4f18edd501035c0475 passed
Test Ok

@banool banool force-pushed the banool/crates_e_to_h branch from 0728c53 to 96802e5 Compare December 8, 2022 15:12
@JoshLind JoshLind disabled auto-merge December 8, 2022 15:13
@JoshLind JoshLind merged commit 2d7a455 into main Dec 8, 2022
@JoshLind JoshLind deleted the banool/crates_e_to_h branch December 8, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLind JoshLind JoshLind approved these changes

@msmouse msmouse Awaiting requested review from msmouse msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark is a code owner

@bchocho bchocho Awaiting requested review from bchocho bchocho is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@clay-aptos clay-aptos Awaiting requested review from clay-aptos

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 is a code owner

@gelash gelash Awaiting requested review from gelash gelash is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 is a code owner

Assignees
No one assigned
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR. CICD:run-coverage run tests with test coverage instrumentation CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banool @JoshLind