[DOC] add aptos wallet adapter docs #5812

0xmaayan · 2022-12-07T21:41:26Z

Description

Adds documentation for Aptos Wallet Adapter under the "BUILD APPS" section

Test Plan

clay-aptos

This looks great, Maayan. Please give me until tomorrow EOD to review.

developer-docs-site/docs/concepts/wallet-adapter-concept.md

clay-aptos · 2022-12-08T19:45:53Z

developer-docs-site/docs/guides/wallet-adapter-for-dapp.md

+npm install @aptos-labs/wallet-adapter-react
+```
+
+Import dependencies.


How import dependencies?

maybe a title should fit better here, fixed it

clay-aptos · 2022-12-08T19:46:54Z

developer-docs-site/docs/guides/wallet-adapter-for-dapp.md

+On the App.jsx file, Import the installed wallets.
+
+```js
+import { AptosWallet } from "some-aptos-wallet-package";


Can we give them an actual example to accompany some-aptos-wallet-package here

clay-aptos

Great work, @0xmaayan ! I made some edits directly to the files. And I included one TODO asking for how to import dependencies. Once that is resolved, this LGTM. Thanks again!

davidiw · 2022-12-09T01:25:56Z

developer-docs-site/docs/concepts/wallet-adapter-concept.md

+
+# Aptos Wallet Adapter
+
+Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.


Suggested change

Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.

We provide an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.

davidiw · 2022-12-09T01:26:59Z

developer-docs-site/docs/concepts/wallet-adapter-concept.md

+
+Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.
+
+The Aptos Wallet Adapter acts as a service between dapps and wallets and exposes APIs for dapps to interact with the wallets by following our [Wallet Standard](../guides/wallet-standard).


Suggested change

The Aptos Wallet Adapter acts as a service between dapps and wallets and exposes APIs for dapps to interact with the wallets by following our [Wallet Standard](../guides/wallet-standard).

The Aptos Wallet Adapter acts as a service between dapps and wallets and exposes APIs for dapps to interact with wallets following our [Wallet Standard](../guides/wallet-standard). This in turns allows dapps to support many wallets with minimal integration efforts.

davidiw · 2022-12-09T01:29:44Z

developer-docs-site/docs/concepts/wallet-adapter-concept.md

+
+# Aptos Wallet Adapter
+
+Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.


these paragraphs don't really describe the problem that the wallet adapter is addressing...

There are a lot of wallets in the ecosystem

Supporting each one is a burden but not supporting them is risky for projects

Integration with wallets can be a complex process that requires a lot of testing

A wallet adapter solves these pain points....

or something

we explain it here in details, https://github.com/aptos-labs/aptos-core/pull/5812/files#diff-28a8dc8c00ae95b5f3d12241e42fbdcaf8e022df85c141d748d8de3cb2113001R8-R23

but we can also add some on that page! maybe benefits for both wallets and dapps

0xmaayan · 2022-12-09T05:05:14Z

@clay-aptos please re-review the changes on https://github.com/aptos-labs/aptos-core/pull/5812/files#diff-bc6f3c4dd609b1b3fdf0dffba82abeb7e30e4d788a37b8f2370430171f5287fe

clay-aptos

Thank you, Maayan! This LGTM with some small changes I made directly. Thanks again!

github-actions · 2022-12-09T20:21:38Z

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `968af5b35e2f360023f28fa06b661569e5987f02`

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 968af5b35e2f360023f28fa06b661569e5987f02 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7695 TPS, 5274 ms latency, 8300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 968af5b35e2f360023f28fa06b661569e5987f02
compatibility::simple-validator-upgrade::single-validator-upgrade : 4328 TPS, 8958 ms latency, 12200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 968af5b35e2f360023f28fa06b661569e5987f02
compatibility::simple-validator-upgrade::half-validator-upgrade : 4606 TPS, 9139 ms latency, 12400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 968af5b35e2f360023f28fa06b661569e5987f02
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6196 TPS, 6134 ms latency, 10000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 968af5b35e2f360023f28fa06b661569e5987f02 passed
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

github-actions · 2022-12-09T20:24:27Z

✅ Forge suite `land_blocking` success on `968af5b35e2f360023f28fa06b661569e5987f02`

performance benchmark with full nodes : 6101 TPS, 6501 ms latency, 10500 ms p99 latency,no expired txns
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

* [DOC] add aptos wallet adapter docs * [DOC] add aptos wallet adapter docs * [DOC] add aptos wallet adapter docs * import image and baseUrl components * add missing link * rename image files * add words to dict file * Make direct edits to Wallet Adapter concept * Make direct edits to Wallet Adapter for Dapps doc * Edit Wallet Adapter for Wallets directly * Fix order of new dictionary entries * address feedback * add context on the adapter * Make small edits directly Co-authored-by: Clay Murphy <114445310+clay-aptos@users.noreply.github.com>

0xmaayan requested a review from gregnazario December 7, 2022 21:41

0xmaayan requested review from davidiw and clay-aptos as code owners December 7, 2022 21:41

clay-aptos requested a review from kent-white December 7, 2022 22:22

clay-aptos reviewed Dec 7, 2022

View reviewed changes

0xmaayan commented Dec 7, 2022

View reviewed changes

developer-docs-site/docs/concepts/wallet-adapter-concept.md Outdated Show resolved Hide resolved

clay-aptos reviewed Dec 8, 2022

View reviewed changes

clay-aptos suggested changes Dec 8, 2022

View reviewed changes

0xmaayan force-pushed the wallet_adapter_docs branch from c1d4851 to db2784f Compare December 9, 2022 01:01

davidiw reviewed Dec 9, 2022

View reviewed changes

clay-aptos approved these changes Dec 9, 2022

View reviewed changes

github-actions bot approved these changes Dec 9, 2022

View reviewed changes

0xmaayan and others added 14 commits December 9, 2022 11:19

[DOC] add aptos wallet adapter docs

6442d7e

[DOC] add aptos wallet adapter docs

69d039b

[DOC] add aptos wallet adapter docs

ef9e98d

import image and baseUrl components

01e568d

add missing link

bbe662a

rename image files

624acf1

add words to dict file

3f73b88

Make direct edits to Wallet Adapter concept

400941e

Make direct edits to Wallet Adapter for Dapps doc

c00de67

Edit Wallet Adapter for Wallets directly

9d74075

Fix order of new dictionary entries

8b7d0ce

address feedback

3f202b1

add context on the adapter

5514461

Make small edits directly

783ae28

0xmaayan force-pushed the wallet_adapter_docs branch from 494b3ee to 783ae28 Compare December 9, 2022 19:19

0xmaayan enabled auto-merge (squash) December 9, 2022 19:19

This comment has been minimized.

Sign in to view

add words to dict file

968af5b

0xmaayan merged commit 367519a into main Dec 9, 2022

0xmaayan deleted the wallet_adapter_docs branch December 9, 2022 19:57

This comment has been minimized.

Sign in to view

Markuze mentioned this pull request Dec 26, 2022

markuze/aptos perf #5998

Closed

Markuze mentioned this pull request Jan 3, 2023

[Network] Adding AptosPerf Client #6054

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DOC] add aptos wallet adapter docs #5812

[DOC] add aptos wallet adapter docs #5812

0xmaayan commented Dec 7, 2022

clay-aptos left a comment

clay-aptos Dec 8, 2022

0xmaayan Dec 9, 2022

clay-aptos Dec 8, 2022

0xmaayan Dec 9, 2022

clay-aptos left a comment

davidiw Dec 9, 2022

davidiw Dec 9, 2022

davidiw Dec 9, 2022

0xmaayan Dec 9, 2022 •

edited

Loading

0xmaayan commented Dec 9, 2022

clay-aptos left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022


		# Aptos Wallet Adapter

		Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.

	Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.
	We provide an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.


		Aptos provides an [Aptos Wallet Adapter](https://github.com/aptos-labs/aptos-wallet-adapter) monorepo for wallet and dapps creators to ease development and ensure a smooth process in building projects on the Aptos network.

		The Aptos Wallet Adapter acts as a service between dapps and wallets and exposes APIs for dapps to interact with the wallets by following our [Wallet Standard](../guides/wallet-standard).

[DOC] add aptos wallet adapter docs #5812

[DOC] add aptos wallet adapter docs #5812

Conversation

0xmaayan commented Dec 7, 2022

Description

Test Plan

clay-aptos left a comment

Choose a reason for hiding this comment

clay-aptos Dec 8, 2022

Choose a reason for hiding this comment

0xmaayan Dec 9, 2022

Choose a reason for hiding this comment

clay-aptos Dec 8, 2022

Choose a reason for hiding this comment

0xmaayan Dec 9, 2022

Choose a reason for hiding this comment

clay-aptos left a comment

Choose a reason for hiding this comment

davidiw Dec 9, 2022

Choose a reason for hiding this comment

davidiw Dec 9, 2022

Choose a reason for hiding this comment

davidiw Dec 9, 2022

Choose a reason for hiding this comment

0xmaayan Dec 9, 2022 • edited Loading

Choose a reason for hiding this comment

0xmaayan commented Dec 9, 2022

clay-aptos left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 9, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 968af5b35e2f360023f28fa06b661569e5987f02

github-actions bot commented Dec 9, 2022

✅ Forge suite land_blocking success on 968af5b35e2f360023f28fa06b661569e5987f02

0xmaayan Dec 9, 2022 •

edited

Loading

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `968af5b35e2f360023f28fa06b661569e5987f02`

✅ Forge suite `land_blocking` success on `968af5b35e2f360023f28fa06b661569e5987f02`