-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup][indexer] Clean up unused protos and add new proto for grpc #5761
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
I can see this PR removes the |
We'll add |
@ppoliani We removed that piece of code b/c it's unmaintained (both firehose-stream and extractor.proto). We are building a grpc endpoint so I'm sort of adding it back, but we make no guarantee that the schema will be the same b/c we are not integrated with StreamingFast's Firehose service. If you want to maintain the integration the best way is to create your own fork. |
@bowenyang007 thank you for the clarification. Does it mean that this config will also become obsolete? I'm currently running this firehose-enabled node . Should I expect that future versions of the Aptos node will not work with that code? |
…ptos-labs#5761) * add the Datastream proto v1. * add the Datastream proto v1.
So is |
Unfortunately it's not. |
Description
Test Plan