Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas] consolidate storage charges and makes things configurable #5566

Merged
merged 4 commits into from
Dec 10, 2022

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Nov 15, 2022

Description

Test Plan


This change is Reviewable

@msmouse msmouse added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 15, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse msmouse force-pushed the 1114alden-txn-limits branch 3 times, most recently from 97540ac to 2ab0793 Compare November 15, 2022 19:01
@msmouse msmouse changed the title [gas] trivial: move StorageGasParameters to its own module [gas] consolidate storage charges Nov 15, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse msmouse changed the title [gas] consolidate storage charges [gas] consolidate storage charges and makes things configurable Nov 15, 2022
@msmouse msmouse force-pushed the 1114alden-txn-limits branch from bea73f0 to d7ecd86 Compare November 15, 2022 21:23
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse msmouse force-pushed the 1114alden-txn-limits branch 3 times, most recently from 263065c to e7fc534 Compare November 15, 2022 23:53
@msmouse msmouse marked this pull request as ready for review November 15, 2022 23:53
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse msmouse force-pushed the 1114alden-txn-limits branch from 9cce851 to 2a6c57c Compare December 9, 2022 18:38
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse msmouse force-pushed the 1114alden-txn-limits branch from 2a6c57c to 989bc9d Compare December 9, 2022 21:33
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse msmouse force-pushed the 1114alden-txn-limits branch from 989bc9d to 49ae91a Compare December 10, 2022 00:09
@msmouse
Copy link
Contributor Author

msmouse commented Dec 10, 2022

I replay-verifyed the entirety of the mainnet history with this and it passed.

@msmouse msmouse closed this Dec 10, 2022
@msmouse msmouse reopened this Dec 10, 2022
@msmouse msmouse enabled auto-merge (rebase) December 10, 2022 00:10
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 49ae91a133596b518c47505a1d0373d04b918c55

performance benchmark with full nodes : 6370 TPS, 6251 ms latency, 9100 ms p99 latency,(!) expired 120 out of 2720140 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 49ae91a133596b518c47505a1d0373d04b918c55

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 49ae91a133596b518c47505a1d0373d04b918c55 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7514 TPS, 5165 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 49ae91a133596b518c47505a1d0373d04b918c55
compatibility::simple-validator-upgrade::single-validator-upgrade : 4424 TPS, 8968 ms latency, 12100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 49ae91a133596b518c47505a1d0373d04b918c55
compatibility::simple-validator-upgrade::half-validator-upgrade : 4302 TPS, 9680 ms latency, 12900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 49ae91a133596b518c47505a1d0373d04b918c55
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6288 TPS, 6133 ms latency, 10800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 49ae91a133596b518c47505a1d0373d04b918c55 passed
Test Ok

@msmouse msmouse merged commit f4466bb into main Dec 10, 2022
@msmouse msmouse deleted the 1114alden-txn-limits branch December 10, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants