-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gas] consolidate storage charges and makes things configurable #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmouse
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Nov 15, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
force-pushed
the
1114alden-txn-limits
branch
3 times, most recently
from
November 15, 2022 19:01
97540ac
to
2ab0793
Compare
msmouse
changed the title
[gas] trivial: move StorageGasParameters to its own module
[gas] consolidate storage charges
Nov 15, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
changed the title
[gas] consolidate storage charges
[gas] consolidate storage charges and makes things configurable
Nov 15, 2022
msmouse
force-pushed
the
1114alden-txn-limits
branch
from
November 15, 2022 21:23
bea73f0
to
d7ecd86
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
force-pushed
the
1114alden-txn-limits
branch
3 times, most recently
from
November 15, 2022 23:53
263065c
to
e7fc534
Compare
msmouse
requested review from
JoshLind,
lightmark,
davidiw,
movekevin,
wrwg,
zekun000 and
vgao1996
as code owners
November 15, 2022 23:53
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
force-pushed
the
1114alden-txn-limits
branch
from
December 9, 2022 18:38
9cce851
to
2a6c57c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
force-pushed
the
1114alden-txn-limits
branch
from
December 9, 2022 21:33
2a6c57c
to
989bc9d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
force-pushed
the
1114alden-txn-limits
branch
from
December 10, 2022 00:09
989bc9d
to
49ae91a
Compare
I |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
This change is