Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-ary merkle #5548

Closed
wants to merge 21 commits into from
Closed

x-ary merkle #5548

wants to merge 21 commits into from

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Nov 13, 2022 •
edited by geekflyer
Loading

Description

Test Plan

This change is Reviewable

msmouse
msmouse reviewed Nov 30, 2022
View reviewed changes
crates/aptos-crypto/src/hash.rs Outdated Show resolved Hide resolved
crates/aptos-push-metrics/src/lib.rs Outdated Show resolved Hide resolved
execution/executor-benchmark/src/lib.rs Outdated Show resolved Hide resolved
storage/jellyfish-merkle/src/lib.rs
Comment on lines +963 to +964
let nibble_path = NibblePath::new_from_bytes(self.as_slice(), ROOT_NIBBLE_HEIGHT);
nibble_path.get_nibble(index)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be inefficient

@zjma
Copy link
Contributor Author

zjma commented Jan 3, 2023

@grao1991 @msmouse is this still interesting?

@davidiw
Copy link
Contributor

davidiw commented Feb 15, 2023

stale?

@davidiw davidiw closed this Feb 15, 2023
@davidiw davidiw deleted the x-ary-merkle branch February 15, 2023 16:34
@zjma zjma restored the x-ary-merkle branch March 25, 2023 19:16
@zjma
Copy link
Contributor Author

zjma commented Mar 27, 2023

Didn't know we cleaned up. I will run some experiments and re-delete soon.

@snyk-bot snyk-bot mentioned this pull request Apr 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse msmouse left review comments

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@alinush alinush Awaiting requested review from alinush alinush will be requested when the pull request is marked ready for review alinush is a code owner

@mstraka100 mstraka100 Awaiting requested review from mstraka100 mstraka100 will be requested when the pull request is marked ready for review mstraka100 is a code owner

@rex1fernando rex1fernando Awaiting requested review from rex1fernando rex1fernando will be requested when the pull request is marked ready for review rex1fernando is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjma @davidiw @msmouse