-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Use simulation errors from API #5526
Conversation
This looks fine, let's get it tested and in... I'd be fine with just eye balling it... |
API Errors for simulation are fixed, so we use these now. Additionally, gas estimation and associated TODOs are cleaned up.
cef25a4
to
eece5d2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, what if someone relies on simulate_transaction
? I suppose the Rust SDK probably isn't considered at 1.0.0 yet though, so not a big deal. Though if there is a way to make simulate_transaction
call into the new function that'd be good.
Deleted function is in the CLI, so unless someone's building on top of internal functions in the CLI, it should be fine. |
Description
The API errors for simulation are fixed, so we will use those now in the cli rather than fetching from the ABI
Test Plan
Tested manually as both a success and a failure:
This change is