[smoke-test] Removing clean state dependency of some tests #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrwg
added
the
CICD:run-e2e-tests
bchocho
reviewed
Jul 21, 2022
config/global-constants/src/lib.rs
Outdated
| @@ -22,5 +22,5 @@ pub const VALIDATOR_NETWORK_KEY: &str = "validator_network"; | |||
| pub const SAFETY_DATA: &str = "safety_data"; | |||
| pub const WAYPOINT: &str = "waypoint"; | |||
| pub const GENESIS_WAYPOINT: &str = "genesis-waypoint"; | |||
| pub const MOVE_MODULES: &str = "move_modules"; | |||
| pub const MOVE_MODULES: &str = "module_publish_modules"; | |||
There was a problem hiding this comment.
Is this an intended change? Seems out of scope of the smoke-test
There was a problem hiding this comment.
Oh! That was jetbrains refactor renaming...
bchocho
reviewed
Jul 21, 2022
| public fun foo(addr: address): u64 { | ||
| coin::balance<AptosCoin>(addr) | ||
| } | ||
| } |
There was a problem hiding this comment.
Some linter may complain about the newline.
Refines aptos-labs#2140 to fix flakiness.
✅ Forge test successForge is land-blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refines #2140 to fix flakiness.
Test Plan
Existing tests, less flaky
This change is