Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick certain optimization PRs #15612

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

vineethk
Copy link
Contributor

Copy link

trunk-io bot commented Dec 16, 2024

⏱️ 2h 9m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 28m 🟩
rust-unit-tests 26m 🟩
execution-performance / single-node-performance 24m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-doc-tests 6m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 4m 🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
check-dynamic-deps 1m 🟩🟩
check 1m 🟥
general-lints 51s 🟩🟩
semgrep/ci 45s 🟩🟩
file_change_determinator 21s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 24m 16m +50%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vineethk vineethk requested review from sherry-x and rahxephon89 and removed request for davidiw, wrwg and movekevin December 16, 2024 17:28
Copy link

trunk-io bot commented Dec 16, 2024

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@vineethk vineethk enabled auto-merge (squash) December 16, 2024 19:31

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on c0a4b90c957e8695706c65ffad910dde924075e1 ==> bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd

Compatibility test results for c0a4b90c957e8695706c65ffad910dde924075e1 ==> bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd (PR)
1. Check liveness of validators at old version: c0a4b90c957e8695706c65ffad910dde924075e1
compatibility::simple-validator-upgrade::liveness-check : committed: 17228.78 txn/s, latency: 1971.54 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2400 ms), latency samples: 557160
2. Upgrading first Validator to new version: bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7069.29 txn/s, latency: 4010.30 ms, (p50: 4500 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 130280
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6978.29 txn/s, latency: 4651.19 ms, (p50: 4800 ms, p70: 4900, p90: 6200 ms, p99: 6600 ms), latency samples: 230060
3. Upgrading rest of first batch to new version: bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6646.60 txn/s, latency: 4265.71 ms, (p50: 4800 ms, p70: 5200, p90: 5400 ms, p99: 5700 ms), latency samples: 123760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6785.34 txn/s, latency: 4870.00 ms, (p50: 5100 ms, p70: 5300, p90: 5900 ms, p99: 6600 ms), latency samples: 234780
4. upgrading second batch to new version: bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11607.83 txn/s, latency: 2394.86 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 201120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11952.53 txn/s, latency: 2688.74 ms, (p50: 2700 ms, p70: 2900, p90: 3100 ms, p99: 3200 ms), latency samples: 387020
5. check swarm health
Compatibility test for c0a4b90c957e8695706c65ffad910dde924075e1 ==> bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd

two traffics test: inner traffic : committed: 14876.37 txn/s, latency: 2667.15 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5656340
two traffics test : committed: 99.94 txn/s, latency: 1383.77 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1700 ms), latency samples: 1880
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.528, avg: 1.461", "ConsensusProposalToOrdered: max: 0.319, avg: 0.290", "ConsensusOrderedToCommit: max: 0.381, avg: 0.370", "ConsensusProposalToCommit: max: 0.668, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.74s no progress at version 32609 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.85s no progress at version 6393368 (avg 0.75s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on c0a4b90c957e8695706c65ffad910dde924075e1 ==> bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd

Compatibility test results for c0a4b90c957e8695706c65ffad910dde924075e1 ==> bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd (PR)
Upgrade the nodes to version: bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1408.77 txn/s, submitted: 1411.29 txn/s, failed submission: 2.52 txn/s, expired: 2.52 txn/s, latency: 2316.29 ms, (p50: 2100 ms, p70: 2300, p90: 3700 ms, p99: 5100 ms), latency samples: 111960
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1341.97 txn/s, submitted: 1343.52 txn/s, failed submission: 1.56 txn/s, expired: 1.56 txn/s, latency: 2158.00 ms, (p50: 1800 ms, p70: 2300, p90: 3300 ms, p99: 5100 ms), latency samples: 120820
5. check swarm health
Compatibility test for c0a4b90c957e8695706c65ffad910dde924075e1 ==> bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd passed
Upgrade the remaining nodes to version: bc6b0afc2e2a4869f1d2c9b7a2320d77a7959ebd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1495.40 txn/s, submitted: 1497.69 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2055.94 ms, (p50: 2100 ms, p70: 2400, p90: 2700 ms, p99: 3900 ms), latency samples: 131000
Test Ok

@vineethk vineethk merged commit 3402522 into aptos-release-v1.25 Dec 16, 2024
90 of 92 checks passed
@vineethk vineethk deleted the vk/cherry-pick-opt-prs branch December 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants