Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix private key field being required #15546

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

GhostWalker562
Copy link
Contributor

Description

When defining deserialize_with, if the field is missing, it will throw an error. By adding a default we are able to default it to Option::None

How Has This Been Tested?

  • Works with prefixed private keys
  • Works with ledger derivation path
  • Works with private keys

Key Areas to Review

Any edge cases with invalid or missing fields

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 9, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Forge suite realistic_env_max_load success on 9307b1a216928b32f96a4b62fc2be31900e78eb3

two traffics test: inner traffic : committed: 15009.97 txn/s, latency: 2646.84 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5707260
two traffics test : committed: 100.05 txn/s, latency: 1389.33 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2100 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.511, avg: 1.442", "ConsensusProposalToOrdered: max: 0.326, avg: 0.288", "ConsensusOrderedToCommit: max: 0.371, avg: 0.357", "ConsensusProposalToCommit: max: 0.656, avg: 0.645"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 16193 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.58s no progress at version 2885348 (avg 0.58s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9307b1a216928b32f96a4b62fc2be31900e78eb3

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9307b1a216928b32f96a4b62fc2be31900e78eb3 (PR)
Upgrade the nodes to version: 9307b1a216928b32f96a4b62fc2be31900e78eb3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1389.90 txn/s, submitted: 1392.59 txn/s, failed submission: 2.69 txn/s, expired: 2.69 txn/s, latency: 2190.78 ms, (p50: 2000 ms, p70: 2100, p90: 3300 ms, p99: 4500 ms), latency samples: 123840
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1228.02 txn/s, submitted: 1230.26 txn/s, failed submission: 2.24 txn/s, expired: 2.24 txn/s, latency: 2468.43 ms, (p50: 2400 ms, p70: 2700, p90: 3400 ms, p99: 5200 ms), latency samples: 109420
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9307b1a216928b32f96a4b62fc2be31900e78eb3 passed
Upgrade the remaining nodes to version: 9307b1a216928b32f96a4b62fc2be31900e78eb3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1370.71 txn/s, submitted: 1374.45 txn/s, failed submission: 3.75 txn/s, expired: 3.75 txn/s, latency: 2157.69 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4400 ms), latency samples: 124380
Test Ok

Copy link
Contributor

github-actions bot commented Dec 9, 2024

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9307b1a216928b32f96a4b62fc2be31900e78eb3

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9307b1a216928b32f96a4b62fc2be31900e78eb3 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 16769.56 txn/s, latency: 2017.51 ms, (p50: 2100 ms, p70: 2100, p90: 2300 ms, p99: 3600 ms), latency samples: 548060
2. Upgrading first Validator to new version: 9307b1a216928b32f96a4b62fc2be31900e78eb3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5500.36 txn/s, latency: 5288.93 ms, (p50: 5800 ms, p70: 6400, p90: 6700 ms, p99: 7200 ms), latency samples: 103940
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5498.22 txn/s, latency: 6036.78 ms, (p50: 6600 ms, p70: 6700, p90: 6900 ms, p99: 7000 ms), latency samples: 189480
3. Upgrading rest of first batch to new version: 9307b1a216928b32f96a4b62fc2be31900e78eb3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7315.77 txn/s, latency: 3901.11 ms, (p50: 4400 ms, p70: 4700, p90: 4800 ms, p99: 4800 ms), latency samples: 136520
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7530.86 txn/s, latency: 4334.40 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5100 ms), latency samples: 252220
4. upgrading second batch to new version: 9307b1a216928b32f96a4b62fc2be31900e78eb3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 3124.86 txn/s, submitted: 3125.02 txn/s, expired: 0.17 txn/s, latency: 2386.56 ms, (p50: 2600 ms, p70: 2800, p90: 3000 ms, p99: 3100 ms), latency samples: 204389
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11821.83 txn/s, latency: 2709.45 ms, (p50: 2800 ms, p70: 3000, p90: 3100 ms, p99: 3400 ms), latency samples: 385880
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9307b1a216928b32f96a4b62fc2be31900e78eb3 passed
Test Ok

@gregnazario gregnazario merged commit f3319d1 into main Dec 9, 2024
87 of 88 checks passed
@gregnazario gregnazario deleted the fix-private-key-field branch December 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants