[VM][Code cache v2] Some improvements in code cache #15537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 5h 52m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
ziaptos
commented
Dec 8, 2024
|
|
||
| if prev_idx.is_some() { |
There was a problem hiding this comment.
Removed this as it can never happen - the Some(idx) case is dealt with under the same write lock!
There was a problem hiding this comment.
This is more of a paranoid check, but yes, tis is unreachable so removing should be ok
georgemitenkov
added
CICD:run-execution-performance-test
georgemitenkov
approved these changes
Dec 9, 2024
| module: module_id, | ||
| name: struct_name.to_owned(), | ||
| })?); | ||
| }; | ||
| struct_names.push(struct_name_index_map.struct_name_to_idx(&struct_name)?); |
There was a problem hiding this comment.
Seems a bit wasteful passing by ref here, but I guess we do not expect miss es to happen often in any case?
There was a problem hiding this comment.
By reference should actually be more efficient, but compiler optimizations would probably make them the same, or similar.
| let idx = index_map.backward_map.len(); | ||
| let prev_idx = index_map.forward_map.insert(struct_name.clone(), idx); | ||
| index_map.backward_map.push(Arc::new(struct_name)); | ||
| // Possibly need to insert, so make the copies outside of the lock |
There was a problem hiding this comment.
nit: . in the end of a sentence?
gelash
approved these changes
Dec 11, 2024
| ) -> PartialVMResult<&'a Arc<StructIdentifier>> { | ||
| index_map.backward_map.get(idx.0).ok_or_else(|| { | ||
| let msg = format!( | ||
| "Index out of bounds when accessing struct name reference \ |
There was a problem hiding this comment.
some of hthe other messages were "when constructing a struct tag" and "when accessing struct name at index". Not sure if we should support custom error messages for use-cases, it's beautiful with the helper - but maybe we can make the error message more generic.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
georgemitenkov
pushed a commit
that referenced
this pull request
Jan 6, 2025
* some improvements in code cache * more refactoring * fixed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small code optimizations (weaker lock in to avoid readers to wait)
How Has This Been Tested?
Existing tests
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist