Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FA migration] coin withdraw + FA deposit events for FA migration #15520

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

lightmark
Copy link
Contributor

@lightmark lightmark commented Dec 5, 2024

Description

we are migrating coin to fa.

it should not be considered as a coin withdraw + deposit event.
Also the deposit function should bypass deposit_sanity_check since it is an internal transfer to themselves.

How Has This Been Tested?

exchanges.

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 5, 2024

⏱️ 2h 29m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 45m 🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
rust-move-tests 7m
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 3m 🟩🟩🟩🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
rust-move-tests 2m
general-lints 2m 🟩🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark requested a review from igor-aptos December 5, 2024 23:41
@lightmark lightmark force-pushed the lightmark/no_deposit_for_migration branch from 8b5dbbd to 57df290 Compare December 5, 2024 23:43
@lightmark lightmark force-pushed the lightmark/no_deposit_for_migration branch from 57df290 to 7456ac5 Compare December 6, 2024 00:31
@lightmark lightmark changed the title [FA migration] no FA deposit event for FA migration [FA migration] coin withdraw + FA deposit events for FA migration Dec 6, 2024
@lightmark lightmark enabled auto-merge (squash) December 6, 2024 02:52

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

✅ Forge suite compat success on 17f4b41fb7157192dd4980b292843d84c518ea70 ==> 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d

Compatibility test results for 17f4b41fb7157192dd4980b292843d84c518ea70 ==> 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d (PR)
1. Check liveness of validators at old version: 17f4b41fb7157192dd4980b292843d84c518ea70
compatibility::simple-validator-upgrade::liveness-check : committed: 15644.25 txn/s, latency: 2093.71 ms, (p50: 1700 ms, p70: 1800, p90: 2400 ms, p99: 14100 ms), latency samples: 540820
2. Upgrading first Validator to new version: 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6962.16 txn/s, latency: 4065.43 ms, (p50: 4600 ms, p70: 4900, p90: 5000 ms, p99: 5000 ms), latency samples: 129360
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6925.18 txn/s, latency: 4643.58 ms, (p50: 5000 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 235480
3. Upgrading rest of first batch to new version: 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7358.66 txn/s, latency: 3865.89 ms, (p50: 4300 ms, p70: 4600, p90: 4700 ms, p99: 4900 ms), latency samples: 135020
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7548.24 txn/s, latency: 4331.35 ms, (p50: 4600 ms, p70: 4700, p90: 4900 ms, p99: 5400 ms), latency samples: 252020
4. upgrading second batch to new version: 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10229.06 txn/s, latency: 2702.60 ms, (p50: 2400 ms, p70: 3000, p90: 4200 ms, p99: 4500 ms), latency samples: 185220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10304.64 txn/s, latency: 3082.34 ms, (p50: 2600 ms, p70: 4100, p90: 4500 ms, p99: 4800 ms), latency samples: 342300
5. check swarm health
Compatibility test for 17f4b41fb7157192dd4980b292843d84c518ea70 ==> 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d passed
Test Ok

Copy link
Contributor

github-actions bot commented Dec 6, 2024

✅ Forge suite realistic_env_max_load success on 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d

two traffics test: inner traffic : committed: 14999.18 txn/s, latency: 2647.72 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5703000
two traffics test : committed: 100.01 txn/s, latency: 1381.30 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1600 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.515, avg: 1.449", "ConsensusProposalToOrdered: max: 0.312, avg: 0.288", "ConsensusOrderedToCommit: max: 0.377, avg: 0.367", "ConsensusProposalToCommit: max: 0.664, avg: 0.655"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 16313 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.62s no progress at version 2639056 (avg 0.62s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 6, 2024

✅ Forge suite framework_upgrade success on 17f4b41fb7157192dd4980b292843d84c518ea70 ==> 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d

Compatibility test results for 17f4b41fb7157192dd4980b292843d84c518ea70 ==> 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d (PR)
Upgrade the nodes to version: 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1340.27 txn/s, submitted: 1341.83 txn/s, failed submission: 1.56 txn/s, expired: 1.56 txn/s, latency: 2265.35 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4200 ms), latency samples: 120080
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1441.60 txn/s, submitted: 1445.41 txn/s, failed submission: 3.81 txn/s, expired: 3.81 txn/s, latency: 2133.87 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4000 ms), latency samples: 128740
5. check swarm health
Compatibility test for 17f4b41fb7157192dd4980b292843d84c518ea70 ==> 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d passed
Upgrade the remaining nodes to version: 7456ac5d800b60b8a08fdfd0f0c4d85c117ee54d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1413.57 txn/s, submitted: 1417.86 txn/s, failed submission: 4.29 txn/s, expired: 4.29 txn/s, latency: 2182.02 ms, (p50: 2100 ms, p70: 2200, p90: 3200 ms, p99: 4900 ms), latency samples: 125180
Test Ok

@lightmark lightmark merged commit 8a1016a into main Dec 6, 2024
127 of 139 checks passed
@lightmark lightmark deleted the lightmark/no_deposit_for_migration branch December 6, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants