Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scenario test txns for fungible asset processor #15422

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

rtso
Copy link
Contributor

@rtso rtso commented Nov 27, 2024

Description

Adds the following test transactions for fungible asset processor:

Scripted transactions

  • Transfer + burn coin / FA (same transaction)
  • Transfer A to B to C coin / FA (same transaction)

Imported transactions

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 27, 2024

⏱️ 3h 50m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 23m 🟥🟩
dispatch_event 21m 🟩
dispatch_event 20m 🟩
execution-performance / test-target-determinator 15m 🟩🟩🟩
forge-e2e-test / forge 14m 🟥
test-target-determinator 14m 🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
check 11m 🟩🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
dispatch_event 7m 🟥
rust-doc-tests 6m 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 22m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

rtso commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rtso rtso changed the title add scripted fa txn Add scenario test txns for fungible asset processor Nov 28, 2024
@rtso rtso requested review from dermanyang and yuunlimm November 28, 2024 00:50
@rtso rtso marked this pull request as ready for review December 2, 2024 19:42
@rtso rtso enabled auto-merge (rebase) December 3, 2024 23:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite realistic_env_max_load success on d6bb965b4f45b34d438ba2a6b8063019e9fc9c29

two traffics test: inner traffic : committed: 13269.87 txn/s, latency: 3000.18 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 6000 ms), latency samples: 5045540
two traffics test : committed: 99.91 txn/s, latency: 2188.45 ms, (p50: 1800 ms, p70: 2000, p90: 2200 ms, p99: 16700 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.488, avg: 1.425", "ConsensusProposalToOrdered: max: 0.337, avg: 0.295", "ConsensusOrderedToCommit: max: 0.300, avg: 0.291", "ConsensusProposalToCommit: max: 0.595, avg: 0.586"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.01s no progress at version 2211905 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.42s no progress at version 2211903 (avg 15.42s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite compat success on 3527aa2e299553b759c515d9843586bad48c802c ==> d6bb965b4f45b34d438ba2a6b8063019e9fc9c29

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> d6bb965b4f45b34d438ba2a6b8063019e9fc9c29 (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 13298.04 txn/s, latency: 2541.85 ms, (p50: 1800 ms, p70: 2100, p90: 3200 ms, p99: 17200 ms), latency samples: 462200
2. Upgrading first Validator to new version: d6bb965b4f45b34d438ba2a6b8063019e9fc9c29
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3830.34 txn/s, latency: 6958.22 ms, (p50: 7800 ms, p70: 9700, p90: 10100 ms, p99: 10400 ms), latency samples: 75720
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4643.62 txn/s, latency: 7173.69 ms, (p50: 7600 ms, p70: 7800, p90: 8700 ms, p99: 9300 ms), latency samples: 160360
3. Upgrading rest of first batch to new version: d6bb965b4f45b34d438ba2a6b8063019e9fc9c29
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7109.54 txn/s, latency: 3980.30 ms, (p50: 4500 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 131800
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6314.07 txn/s, latency: 4975.01 ms, (p50: 5000 ms, p70: 5100, p90: 6800 ms, p99: 7200 ms), latency samples: 235240
4. upgrading second batch to new version: d6bb965b4f45b34d438ba2a6b8063019e9fc9c29
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10019.44 txn/s, latency: 2716.01 ms, (p50: 2500 ms, p70: 3300, p90: 4100 ms, p99: 4600 ms), latency samples: 179060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9725.37 txn/s, latency: 3131.37 ms, (p50: 2400 ms, p70: 3600, p90: 5600 ms, p99: 7500 ms), latency samples: 318560
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> d6bb965b4f45b34d438ba2a6b8063019e9fc9c29 passed
Test Ok

@rtso rtso merged commit a75189b into main Dec 4, 2024
48 checks passed
@rtso rtso deleted the 11-26-fungible_asset_scenario_test_txns branch December 4, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants