Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: restructure between state related types #15378

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Nov 22, 2024

Description

regroup things
move things out from aptos-types to aptos-storage-interface
remove unused things

How Has This Been Tested?

existing coverage

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Validator Node

Copy link

trunk-io bot commented Nov 22, 2024

⏱️ 3h 12m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 58m 🟩🟥🟩
test-target-determinator 20m 🟩🟩🟩🟩
execution-performance / test-target-determinator 15m 🟩🟩🟩
forge-e2e-test / forge 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
check 11m 🟩🟩🟩
fetch-last-released-docker-image-tag 7m 🟩🟩🟩🟩
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 3m 🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 25m 17m +47%
test-target-determinator 6m 4m +42%

settingsfeedbackdocs ⋅ learn more about trunk.io

@msmouse msmouse added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 22, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@msmouse msmouse enabled auto-merge (squash) November 23, 2024 00:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@msmouse msmouse force-pushed the 1122-alden-restructure-state-types branch from b3b0d83 to b48a7c3 Compare November 25, 2024 21:24

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@msmouse msmouse force-pushed the 1122-alden-restructure-state-types branch from b48a7c3 to 1577f6e Compare November 26, 2024 04:40

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on f436adbe4384d6c5fd296addbb7f52d4be77231b ==> 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e

Compatibility test results for f436adbe4384d6c5fd296addbb7f52d4be77231b ==> 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e (PR)
Upgrade the nodes to version: 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1473.56 txn/s, submitted: 1477.03 txn/s, failed submission: 3.47 txn/s, expired: 3.47 txn/s, latency: 2167.47 ms, (p50: 2100 ms, p70: 2300, p90: 3300 ms, p99: 5100 ms), latency samples: 127300
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1458.40 txn/s, submitted: 1462.88 txn/s, failed submission: 4.48 txn/s, expired: 4.48 txn/s, latency: 2028.29 ms, (p50: 1800 ms, p70: 2100, p90: 3000 ms, p99: 4400 ms), latency samples: 130180
5. check swarm health
Compatibility test for f436adbe4384d6c5fd296addbb7f52d4be77231b ==> 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e passed
Upgrade the remaining nodes to version: 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1495.75 txn/s, submitted: 1499.04 txn/s, failed submission: 3.29 txn/s, expired: 3.29 txn/s, latency: 2276.14 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 4800 ms), latency samples: 127380
Test Ok

Copy link
Contributor

✅ Forge suite compat success on f436adbe4384d6c5fd296addbb7f52d4be77231b ==> 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e

Compatibility test results for f436adbe4384d6c5fd296addbb7f52d4be77231b ==> 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e (PR)
1. Check liveness of validators at old version: f436adbe4384d6c5fd296addbb7f52d4be77231b
compatibility::simple-validator-upgrade::liveness-check : committed: 14743.40 txn/s, latency: 2077.61 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 7500 ms), latency samples: 558180
2. Upgrading first Validator to new version: 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7120.85 txn/s, latency: 3934.16 ms, (p50: 4500 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 132340
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6784.12 txn/s, latency: 4738.37 ms, (p50: 4700 ms, p70: 4700, p90: 7000 ms, p99: 7200 ms), latency samples: 235100
3. Upgrading rest of first batch to new version: 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7734.30 txn/s, latency: 3752.50 ms, (p50: 4100 ms, p70: 4300, p90: 4500 ms, p99: 4600 ms), latency samples: 144980
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7076.17 txn/s, latency: 4599.09 ms, (p50: 4500 ms, p70: 4600, p90: 7000 ms, p99: 7300 ms), latency samples: 265720
4. upgrading second batch to new version: 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12055.93 txn/s, latency: 2303.38 ms, (p50: 2500 ms, p70: 2700, p90: 2800 ms, p99: 3000 ms), latency samples: 207760
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11443.47 txn/s, latency: 2754.00 ms, (p50: 2600 ms, p70: 2700, p90: 4700 ms, p99: 5800 ms), latency samples: 371660
5. check swarm health
Compatibility test for f436adbe4384d6c5fd296addbb7f52d4be77231b ==> 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 1577f6ed4d31e9941b7a4741bf9964fdd6ffc02e

two traffics test: inner traffic : committed: 14300.01 txn/s, latency: 2780.37 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5437180
two traffics test : committed: 99.91 txn/s, latency: 2367.59 ms, (p50: 1800 ms, p70: 2000, p90: 2300 ms, p99: 18500 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.117, avg: 1.332", "ConsensusProposalToOrdered: max: 0.318, avg: 0.291", "ConsensusOrderedToCommit: max: 0.369, avg: 0.359", "ConsensusProposalToCommit: max: 0.658, avg: 0.649"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.22s no progress at version 1927448 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.51s no progress at version 1927446 (avg 15.43s) [limit 16].
Test Ok

@msmouse msmouse merged commit 7b69d4c into main Nov 26, 2024
44 of 47 checks passed
@msmouse msmouse deleted the 1122-alden-restructure-state-types branch November 26, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants