[loader-v2] Remove extra hash calculation from runtime environment

[georgemitenkov]

Description

Before, when deserializing bytes into compiled module, runtime environment also returned size and hash. These were not needed because module cache has an "extension" just for that.

How Has This Been Tested?

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 3h 2m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	23m	🟩
rust-cargo-deny	20m	🟩 🟩 🟩 ⬜ 🟩 (+7 more)
check-dynamic-deps	16m	🟩 🟩 🟩 🟩 🟩 (+7 more)
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
general-lints	5m	🟩 🟩 🟩 ⬜ 🟩 (+7 more)
rust-move-tests	5m	⬜
semgrep/ci	5m	🟩 🟩 🟩 🟩 🟩 (+7 more)

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[georgemitenkov]

• [loader-v2] Remove extra hash calculation from runtime environment #15256 👈
• [loader] Global caches for execution #15192 : 2 other dependent PRs (#15155 , #15255 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite

[github-actions]

✅ Forge suite realistic_env_max_load success on de7b721090ae12c54ce6bdc90eeffa238365da2b

two traffics test: inner traffic : committed: 14208.67 txn/s, latency: 2800.00 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 6300 ms), latency samples: 5402440
two traffics test : committed: 99.94 txn/s, latency: 1478.34 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 10000 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.314, avg: 1.600", "ConsensusProposalToOrdered: max: 0.316, avg: 0.295", "ConsensusOrderedToCommit: max: 0.383, avg: 0.367", "ConsensusProposalToCommit: max: 0.680, avg: 0.662"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.12s no progress at version 2837304 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.87s no progress at version 2873501 (avg 7.87s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70 ==> de7b721090ae12c54ce6bdc90eeffa238365da2b

Compatibility test results for ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70 ==> de7b721090ae12c54ce6bdc90eeffa238365da2b (PR)
Upgrade the nodes to version: de7b721090ae12c54ce6bdc90eeffa238365da2b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1387.82 txn/s, submitted: 1390.31 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2249.10 ms, (p50: 2100 ms, p70: 2100, p90: 3600 ms, p99: 5500 ms), latency samples: 122780
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1274.50 txn/s, submitted: 1276.03 txn/s, failed submission: 1.53 txn/s, expired: 1.53 txn/s, latency: 2359.46 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5100 ms), latency samples: 116280
5. check swarm health
Compatibility test for ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70 ==> de7b721090ae12c54ce6bdc90eeffa238365da2b passed
Upgrade the remaining nodes to version: de7b721090ae12c54ce6bdc90eeffa238365da2b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1236.73 txn/s, submitted: 1239.01 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2506.92 ms, (p50: 2100 ms, p70: 2700, p90: 4800 ms, p99: 5900 ms), latency samples: 108480
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70 ==> de7b721090ae12c54ce6bdc90eeffa238365da2b

Compatibility test results for ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70 ==> de7b721090ae12c54ce6bdc90eeffa238365da2b (PR)
1. Check liveness of validators at old version: ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70
compatibility::simple-validator-upgrade::liveness-check : committed: 13701.75 txn/s, latency: 2468.66 ms, (p50: 1800 ms, p70: 1900, p90: 3600 ms, p99: 18100 ms), latency samples: 466720
2. Upgrading first Validator to new version: de7b721090ae12c54ce6bdc90eeffa238365da2b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8045.60 txn/s, latency: 3581.95 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4300 ms), latency samples: 146980
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7339.08 txn/s, latency: 3991.90 ms, (p50: 4300 ms, p70: 4300, p90: 4400 ms, p99: 5400 ms), latency samples: 272260
3. Upgrading rest of first batch to new version: de7b721090ae12c54ce6bdc90eeffa238365da2b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6330.18 txn/s, latency: 4312.88 ms, (p50: 4700 ms, p70: 5100, p90: 5700 ms, p99: 5900 ms), latency samples: 116560
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7136.98 txn/s, latency: 4527.92 ms, (p50: 4700 ms, p70: 4800, p90: 6300 ms, p99: 6600 ms), latency samples: 239440
4. upgrading second batch to new version: de7b721090ae12c54ce6bdc90eeffa238365da2b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12057.34 txn/s, latency: 2305.95 ms, (p50: 2400 ms, p70: 2600, p90: 3000 ms, p99: 3200 ms), latency samples: 208400
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11491.75 txn/s, latency: 2714.68 ms, (p50: 2600 ms, p70: 3000, p90: 3200 ms, p99: 4700 ms), latency samples: 378260
5. check swarm health
Compatibility test for ea6e45f0eee4b6da2ebf93b9b89d269d334fcf70 ==> de7b721090ae12c54ce6bdc90eeffa238365da2b passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking