fixed determine-test-metadata to use current branch as default branch #14897
+7
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 5m total CI duration on this PR
|
sionescu
approved these changes
Oct 9, 2024
| # on workflow_dispatch, this will simply use the inputs.GIT_SHA given (or the default) | ||
| # on pull_request, this will default to null and the following "checkout" step will use the PR's base branch | ||
| # on workflow_dispatch, this will simply use the inputs.GIT_SHA given (or the default) | ||
| elif [ -n "${{ inputs.GIT_SHA }}" ]; then |
There was a problem hiding this comment.
You should always use the double-bracket operator [[, like above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changed to use current branch as default branch, so the images for testing can be found correctly.
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist