Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trival: cleanup replay-verify workflow #14832

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Oct 1, 2024

Description

remove replay_verify.py and friends

How Has This Been Tested?

manual run

Key Areas to Review

Type of Change

  • Tests

Which Components or Systems Does This Change Impact?

  • Developer Infrastructure

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@msmouse msmouse requested a review from a team as a code owner October 1, 2024 20:43
remove replay_verify.py and friends
@msmouse msmouse force-pushed the 1001-alden-clean-up-replay-verify branch from 476fe0e to 4990813 Compare October 1, 2024 20:44
@msmouse msmouse enabled auto-merge (squash) October 1, 2024 21:27

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Forge suite compat success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 4990813a1ff5369c19d340845c0cafa53ce54556

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 4990813a1ff5369c19d340845c0cafa53ce54556 (PR)
1. Check liveness of validators at old version: 7ef01a26f8d8a38610e3d364b722df517c970749
compatibility::simple-validator-upgrade::liveness-check : committed: 10958.99 txn/s, latency: 3098.59 ms, (p50: 2300 ms, p70: 2800, p90: 6700 ms, p99: 9100 ms), latency samples: 394700
2. Upgrading first Validator to new version: 4990813a1ff5369c19d340845c0cafa53ce54556
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6613.64 txn/s, latency: 4264.06 ms, (p50: 5000 ms, p70: 5200, p90: 5300 ms, p99: 5500 ms), latency samples: 119580
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6208.51 txn/s, latency: 5123.71 ms, (p50: 5200 ms, p70: 5300, p90: 7300 ms, p99: 7700 ms), latency samples: 210460
3. Upgrading rest of first batch to new version: 4990813a1ff5369c19d340845c0cafa53ce54556
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6675.20 txn/s, latency: 4026.70 ms, (p50: 4100 ms, p70: 5200, p90: 5700 ms, p99: 5900 ms), latency samples: 122660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6483.16 txn/s, latency: 4804.57 ms, (p50: 4900 ms, p70: 5100, p90: 7100 ms, p99: 7400 ms), latency samples: 216260
4. upgrading second batch to new version: 4990813a1ff5369c19d340845c0cafa53ce54556
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11169.36 txn/s, latency: 2397.14 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3100 ms), latency samples: 201220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10506.02 txn/s, latency: 3029.15 ms, (p50: 3000 ms, p70: 3200, p90: 3600 ms, p99: 5000 ms), latency samples: 341880
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 4990813a1ff5369c19d340845c0cafa53ce54556 passed
Test Ok

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Forge suite realistic_env_max_load success on 4990813a1ff5369c19d340845c0cafa53ce54556

two traffics test: inner traffic : committed: 13324.85 txn/s, submitted: 13325.00 txn/s, expired: 0.16 txn/s, latency: 2980.03 ms, (p50: 2700 ms, p70: 2700, p90: 3600 ms, p99: 8100 ms), latency samples: 5066440
two traffics test : committed: 99.93 txn/s, latency: 1698.77 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 10600 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.258, avg: 0.227", "QsPosToProposal: max: 0.986, avg: 0.957", "ConsensusProposalToOrdered: max: 0.334, avg: 0.311", "ConsensusOrderedToCommit: max: 0.475, avg: 0.458", "ConsensusProposalToCommit: max: 0.785, avg: 0.768"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.54s no progress at version 5763724 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 9.07s no progress at version 2555983 (avg 9.07s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Forge suite framework_upgrade success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 4990813a1ff5369c19d340845c0cafa53ce54556

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 4990813a1ff5369c19d340845c0cafa53ce54556 (PR)
Upgrade the nodes to version: 4990813a1ff5369c19d340845c0cafa53ce54556
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1305.34 txn/s, submitted: 1307.80 txn/s, failed submission: 2.46 txn/s, expired: 2.46 txn/s, latency: 2335.21 ms, (p50: 2100 ms, p70: 2400, p90: 3700 ms, p99: 5400 ms), latency samples: 116760
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1299.22 txn/s, submitted: 1301.50 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2591.48 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 6100 ms), latency samples: 102500
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 4990813a1ff5369c19d340845c0cafa53ce54556 passed
Upgrade the remaining nodes to version: 4990813a1ff5369c19d340845c0cafa53ce54556
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1173.96 txn/s, submitted: 1175.96 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 2585.94 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5600 ms), latency samples: 105880
Test Ok

@msmouse msmouse merged commit 0811f89 into main Oct 1, 2024
102 of 156 checks passed
@msmouse msmouse deleted the 1001-alden-clean-up-replay-verify branch October 1, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants