simplify transaction list verify code #14783
Draft
+1,933
−1,798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 11h 44m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
9 times, most recently
from
a6413a0
to
b85f4f4
Compare
msmouse
commented
Sep 30, 2024
Comment on lines
276
to
290
| let num_txns = txn_list_with_proof.transactions.len(); | ||
| ensure!(num_txns != 0, "Empty transaction list!"); | ||
| let first_version_in_request = txn_list_with_proof | ||
| .first_transaction_version | ||
| .ok_or_else(|| anyhow!("Non-empty chunk with first_version == None."))?; | ||
| let parent_state = self.commit_queue.lock().latest_state(); | ||
| ensure!( | ||
| first_version_in_request == parent_state.next_version(), | ||
| "Unexpected chunk. version in request: {}, current_version: {:?}", | ||
| first_version_in_request, | ||
| parent_state.current_version, | ||
| ); |
There was a problem hiding this comment.
These are guaranteed if list.verify() passes with Some(expected_version) passed in, specifically, it's guranteed that 1. the list is not empty and 2. the list starts from expected_version
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
from
b85f4f4
to
ae6b08f
Compare
msmouse
added
the
CICD:run-e2e-tests
Forge is running suite
|
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
3 times, most recently
from
8a098a6
to
88b65de
Compare
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
from
88b65de
to
5a3af0e
Compare
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
2 times, most recently
from
eca2910
to
a8b15b2
Compare
msmouse
removed
the
CICD:run-e2e-tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14783 +/- ##
=======================================
Coverage 59.7% 59.7%
=======================================
Files 853 853
Lines 208283 208300 +17
=======================================
+ Hits 124530 124548 +18
+ Misses 83753 83752 -1 ☔ View full report in Codecov by Sentry. |
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
from
a8b15b2
to
73351ba
Compare
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
from
73351ba
to
a1ebce8
Compare
msmouse
force-pushed
the
0927-alden-executor-workflow
branch
from
a1ebce8
to
be1b350
Compare
msmouse
added
CICD:run-execution-performance-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist