Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new runs on image for testing, included gcloud sdk and kubectl #14765

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

yzaccc
Copy link
Contributor

@yzaccc yzaccc commented Sep 26, 2024

Description

Added new runs on image for testing, included gcloud sdk and kubectl.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@yzaccc yzaccc requested a review from a team as a code owner September 26, 2024 19:18
Copy link

trunk-io bot commented Sep 26, 2024

⏱️ 1h 27m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-framework-upgrade-test / forge 19m 🟩
forge-compat-test / forge 19m 🟩
forge-e2e-test / forge 14m 🟩
check-dynamic-deps 8m 🟩🟩🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 1m 🟩
semgrep/ci 57s 🟩🟩🟩
rust-move-tests 56s
general-lints 51s 🟩🟩
file_change_determinator 20s 🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 4m 1m +231%
general-lints 26s 2m -73%
execution-performance / single-node-performance 13s 21m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@yzaccc yzaccc enabled auto-merge (squash) September 26, 2024 19:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 64a2b3a795dece467d97a36ed5258744547f171c

two traffics test: inner traffic : committed: 14025.35 txn/s, latency: 2838.26 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 8100 ms), latency samples: 5332760
two traffics test : committed: 99.96 txn/s, latency: 1812.98 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 18100 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.230", "QsPosToProposal: max: 1.136, avg: 1.064", "ConsensusProposalToOrdered: max: 0.331, avg: 0.298", "ConsensusOrderedToCommit: max: 0.435, avg: 0.418", "ConsensusProposalToCommit: max: 0.728, avg: 0.715"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.98s no progress at version 2970377 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.33s no progress at version 2970375 (avg 8.33s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b6187e1794550f4a6b25cab0e5d40188574241da ==> 64a2b3a795dece467d97a36ed5258744547f171c

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> 64a2b3a795dece467d97a36ed5258744547f171c (PR)
1. Check liveness of validators at old version: b6187e1794550f4a6b25cab0e5d40188574241da
compatibility::simple-validator-upgrade::liveness-check : committed: 16606.86 txn/s, latency: 2042.61 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 2500 ms), latency samples: 539040
2. Upgrading first Validator to new version: 64a2b3a795dece467d97a36ed5258744547f171c
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5169.55 txn/s, latency: 5598.40 ms, (p50: 6200 ms, p70: 6500, p90: 7000 ms, p99: 7200 ms), latency samples: 110080
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7347.14 txn/s, latency: 4346.25 ms, (p50: 4600 ms, p70: 4700, p90: 6000 ms, p99: 6400 ms), latency samples: 244480
3. Upgrading rest of first batch to new version: 64a2b3a795dece467d97a36ed5258744547f171c
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7924.46 txn/s, latency: 3625.84 ms, (p50: 4000 ms, p70: 4100, p90: 4300 ms, p99: 4400 ms), latency samples: 145720
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7156.14 txn/s, latency: 4410.45 ms, (p50: 4300 ms, p70: 4400, p90: 6800 ms, p99: 7300 ms), latency samples: 244860
4. upgrading second batch to new version: 64a2b3a795dece467d97a36ed5258744547f171c
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12725.86 txn/s, latency: 2114.24 ms, (p50: 2300 ms, p70: 2500, p90: 2600 ms, p99: 2700 ms), latency samples: 218220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11498.75 txn/s, latency: 2717.13 ms, (p50: 2600 ms, p70: 2800, p90: 3300 ms, p99: 4600 ms), latency samples: 373840
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> 64a2b3a795dece467d97a36ed5258744547f171c passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b6187e1794550f4a6b25cab0e5d40188574241da ==> 64a2b3a795dece467d97a36ed5258744547f171c

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> 64a2b3a795dece467d97a36ed5258744547f171c (PR)
Upgrade the nodes to version: 64a2b3a795dece467d97a36ed5258744547f171c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1230.48 txn/s, submitted: 1232.48 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 2554.17 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5100 ms), latency samples: 110780
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1278.31 txn/s, submitted: 1279.95 txn/s, failed submission: 1.63 txn/s, expired: 1.63 txn/s, latency: 2440.21 ms, (p50: 2100 ms, p70: 2400, p90: 4000 ms, p99: 5800 ms), latency samples: 109580
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> 64a2b3a795dece467d97a36ed5258744547f171c passed
Upgrade the remaining nodes to version: 64a2b3a795dece467d97a36ed5258744547f171c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1174.11 txn/s, submitted: 1175.95 txn/s, failed submission: 1.84 txn/s, expired: 1.84 txn/s, latency: 2581.32 ms, (p50: 2400 ms, p70: 2900, p90: 3600 ms, p99: 5300 ms), latency samples: 102120
Test Ok

@yzaccc yzaccc merged commit 3467c59 into main Sep 26, 2024
79 of 80 checks passed
@yzaccc yzaccc deleted the yzaccc/install-gcloud-and-plugins-into-runs-on-add-image branch September 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants