Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-chain resources to indicate dkg/randomness failure injection #12345

Merged
merged 6 commits into from
Mar 3, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Mar 2, 2024

Description

Test Plan

Copy link

trunk-io bot commented Mar 2, 2024

⏱️ 9h 22m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 2h 11m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-tests 1h 42m 🟥🟥 (+3 more)
rust-unit-tests 1h 40m 🟥 (+3 more)
rust-move-unit-coverage 1h 23m 🟩🟩 (+3 more)
rust-lints 41m 🟩🟥🟩 (+3 more)
run-tests-main-branch 36m 🟩🟩🟩🟩🟩 (+3 more)
check 30m 🟩🟩🟩 (+3 more)
check-dynamic-deps 17m 🟩🟩🟩🟩🟩 (+3 more)
general-lints 15m 🟩🟩🟩🟩 (+3 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+3 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+3 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+3 more)
permission-check 32s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 32s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 28s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 23s 🟩🟩🟩🟩🟩 (+3 more)

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 23m 18m +32%
rust-unit-tests 38m 31m +24%
windows-build 12m 20m -39%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.2%. Comparing base (8877bae) to head (73d4727).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           preview-randomness   #12345   +/-   ##
===================================================
  Coverage                64.2%    64.2%           
===================================================
  Files                     796      796           
  Lines                  176080   176080           
===================================================
  Hits                   113135   113135           
  Misses                  62945    62945           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjma zjma force-pushed the zjma/block_dkg_randomness branch from a710a0e to a4d54f7 Compare March 2, 2024 06:04
@zjma zjma force-pushed the zjma/block_dkg_randomness branch from ad4c106 to 571fac7 Compare March 2, 2024 06:16
@zjma zjma merged commit 19fc1ee into preview-randomness Mar 3, 2024
44 of 46 checks passed
@zjma zjma deleted the zjma/block_dkg_randomness branch March 3, 2024 01:11
zjma added a commit that referenced this pull request Mar 3, 2024
* randomness type update 3 (#12202)

* randomness #4: RandManager update from randomnet (#12224)

* RandManager update from randomnet

* lint

* lint

* randomness #5: consensus update from randomnet (#12225)

* consensus update from randomnet

* update

* randomness #6: dkg manager update from randomnet (#12226)

* consensus update from randomnet

* update

* update execution client api

* dkg manager update from randomnet

* avoid panic

* make api, indexer, fake aptos db aware of block metadata ext txns (#12227)

* randomness #8: framework update from randomnet (#12228)

* framework update from randomnet

Squashed commit of the following to fix jwk smoke tests:

commit 3bd0154
Author: zhoujun.ma <zhoujun@aptoslabs.com>
Date:   Tue Feb 27 02:47:57 2024 -0800

    update

commit 2eb6add
Author: zhoujun.ma <zhoujun@aptoslabs.com>
Date:   Tue Feb 27 02:12:27 2024 -0800

    update

commit 9d82151
Author: zhoujun.ma <zhoujun@aptoslabs.com>
Date:   Tue Feb 27 01:51:08 2024 -0800

    debug

fix doc test

fix spec

fix doc

update initialization in genesis

update features.move

initialize randomness in genesis

update golden files

private entry fun check and vm updates

* postpone release builder changes

* update goldenfiles

* fix is_safe_call spec

* randomness #9: smoke tests from randomnet (#12282)

* smoke test deps and 1st case from randomnet

* update

* more smoke tests

* randomness #10: randomness API update from randomnet (#12335)

* [move] fixes to `randomness.move` (#12250)

* [move] fixes to randomness.move

* Fixed the Prover spec

Fixed the spec to unblock the PR.

Need to prove the introduced assumptions with proper loop invariants, which should be provable.

* lint

---------

Co-authored-by: Junkil Park <juki14@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>

* fix specs

---------

Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: Junkil Park <juki14@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>

* lint

* update genesis

* on-chain resources to indicate dkg/randomness failure injection (#12345)

* dkg/randomness failure injection

* update

* smoke test

* update

* update

* fix scripts

---------

Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: Junkil Park <juki14@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant