Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add action for sending custom metrics #7

Merged
merged 2 commits into from
Apr 26, 2024
Merged

add action for sending custom metrics #7

merged 2 commits into from
Apr 26, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Mar 19, 2024

Add an action for sending custom metrics to an endpoint

@aluon aluon requested review from sionescu, rustielin and a team March 19, 2024 21:49
rustielin
rustielin requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@rustielin rustielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plan looks good, just some questions above on input validation and batching

send-custom-metrics/action.yaml Show resolved Hide resolved
@aluon aluon force-pushed the aluon/send-custom-metrics branch from 6510ebf to e13cf47 Compare March 19, 2024 23:20
@aluon aluon requested a review from rustielin April 22, 2024 19:09
perryjrandall
perryjrandall approved these changes Apr 22, 2024
View reviewed changes
Copy link

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets ship this as is, looks like it could already be useful for our determinator or random actions

@aluon aluon merged commit 5bc54bf into main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustielin rustielin rustielin approved these changes

@perryjrandall perryjrandall perryjrandall approved these changes

@sionescu sionescu sionescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aluon @sionescu @perryjrandall @rustielin