Print logs in post step for localnet action #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/localnet-post
branch
13 times, most recently
from
c293310 to
f335da7
Compare
banool
changed the title
rustielin
approved these changes
Jun 22, 2024
run-local-testnet/action.yaml
Outdated
| # There is no way to configure post-if with this, so we just always print the logs | ||
| # in the post step. | ||
| - name: Set up printing logs in a post step | ||
| uses: ./with-post-step |
There was a problem hiding this comment.
There's no guarantee that the calling job has this path since it's unlikely to have cloned the entire aptos-labs/actions repo, so you'll likely need to do aptos-labs/actions/with-post-step@main.
| @@ -0,0 +1,18 @@ | |||
| ## Description | |||
|
|
|||
| Generic JS Action to execute a main command and set a command as a post step. | |||
There was a problem hiding this comment.
Copy the important links here too for context:
e.g. actions/runner#1478 and https://github.com/pyTooling/Actions/tree/main/with-post-step
banool
force-pushed
the
banool/localnet-post
branch
from
f335da7 to
ea14225
Compare
banool
force-pushed
the
banool/localnet-post
branch
from
c30c519 to
8c83573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now you can't actually see the logs at the end because the logging steps run before the rest of the job. This way they run as a post step.
Unfortunately we need this post step hack. See actions/runner#1478.