Remove port from server start

apssouza22 · Sep 5, 2020 · ff7159f · ff7159f
1 parent 5c316ae
commit ff7159f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/client/client_test.go b/client/client_test.go
@@ -32,7 +32,7 @@ func startServerWithTLS() grpc_server.GrpcServer {
 	svr.RegisterService(func(server *grpc.Server) {
 		helloworld.RegisterGreeterServer(server, &testdata.MockedService{})
 	})
-	svr.Start("localhost", 8989)
+	svr.Start("localhost:8989")
 	return svr
 }
 

diff --git a/server/server.go b/server/server.go
@@ -20,7 +20,7 @@ import (
 
 //Fiji GRPC server interface
 type GrpcServer interface {
-	Start(address string, port uint) error
+	Start(address string) error
 	AwaitTermination(shutdownHook func())
 	RegisterService(reg func(*grpc.Server))
 	GetListener() net.Listener
@@ -110,10 +110,9 @@ func (s grpcServer) RegisterService(reg func(*grpc.Server)) {
 }
 
 // Start the GRPC server
-func (s *grpcServer) Start(address string, port uint) error {
+func (s *grpcServer) Start(addr string) error {
 	var err error
-	add := fmt.Sprintf("%s:%d", address, port)
-	s.listener, err = net.Listen("tcp", add)
+	s.listener, err = net.Listen("tcp", addr)
 
 	if err != nil {
 		msg := fmt.Sprintf("Failed to listen: %v", err)
@@ -122,7 +121,7 @@ func (s *grpcServer) Start(address string, port uint) error {
 
 	go s.serv()
 
-	log.Infof("grpcServer started on port: %d ", port)
+	log.Infof("gRPC Server started on %s ", addr)
 	return nil
 }
 

diff --git a/server/server_example.go b/server/server_example.go
@@ -36,7 +36,7 @@ func ServerInitialization() {
 	builder.EnableReflection(true)
 	s := builder.Build()
 	s.RegisterService(serviceRegister)
-	err := s.Start("0.0.0.0", 50051)
+	err := s.Start("0.0.0.0:50051")
 	if err != nil {
 		log.Fatalf("%v", err)
 	}
@@ -57,7 +57,7 @@ func ServerInitializationWithTLS() {
 
 	s := builder.Build()
 	s.RegisterService(serviceRegister)
-	err := s.Start("0.0.0.0", 50051)
+	err := s.Start("0.0.0.0:50051")
 	if err != nil {
 		log.Fatalf("%v", err)
 	}