Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
git ls-files -z
dependancy in file listing for inclusion in the gem. This should remove the issues in the deployment actionI chose to go with an explicit manifest set of patterns as it seemed the easiest to control. I tired reading the
.gitignore
file with something like:But
Dir.glob
doesn't process the same patterns as.gitignore
so it included a bunch of extra files. (There were also a bunch of extra files withgit ls-files -z
like the docker files and bin files that were are including unnecessarily)The best library to match the git results seemed to be https://github.com/robotdana/fast_ignore but getting it to install in bundler ahead of the other gems seemed more complicates.
-This also splits the bundle caches (doesn't resolve local issues but just in case the two versions are interfering with each other)