Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce polynomial layer and differentiation #272

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

lkct
Copy link
Member

@lkct lkct commented Sep 25, 2024

As per title.

  • Poly layer supports mult, conj, diff.
    • with tests: symb for all, tensor for mult and diff
    • test with both sum-prod and complex-lse
  • Diff supports poly.

Minor fixes: typos; comments in pytest fixture; signature of allclose in tests

Closes #232

@lkct lkct added the enhancement New feature or request label Sep 25, 2024
@lkct lkct requested a review from loreloc September 25, 2024 15:01
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 76.96629% with 41 lines in your changes missing coverage. Please review.

Project coverage is 71.01%. Comparing base (3a6a98e) to head (77b4a80).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cirkit/backend/torch/layers/input.py 73.68% 6 Missing and 4 partials ⚠️
cirkit/symbolic/layers.py 66.66% 4 Missing and 4 partials ⚠️
cirkit/backend/torch/parameters/nodes.py 80.00% 4 Missing and 3 partials ⚠️
cirkit/symbolic/operators.py 70.00% 3 Missing and 3 partials ⚠️
cirkit/pipeline.py 33.33% 4 Missing ⚠️
cirkit/symbolic/functional.py 88.23% 2 Missing and 2 partials ⚠️
cirkit/symbolic/parameters.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   70.68%   71.01%   +0.32%     
==========================================
  Files          45       45              
  Lines        4575     4744     +169     
  Branches      668      703      +35     
==========================================
+ Hits         3234     3369     +135     
- Misses       1161     1176      +15     
- Partials      180      199      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkct lkct self-assigned this Sep 25, 2024
@loreloc loreloc linked an issue Sep 27, 2024 that may be closed by this pull request
@loreloc loreloc merged commit 1e0d08a into main Sep 27, 2024
3 of 4 checks passed
@loreloc loreloc deleted the poly_layer_and_diff branch September 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back the circuit differential symbolic operation
2 participants