Optimize Dockerfile: Reduce Layers and Improve Build Performance #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SainiAditya1 is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
|
I dont think the build will work like this 🤔 |
|
@TorstenDittmann Thanks for the review , please refer to this article https://docs.docker.com/develop/develop-images/instructions/ . |
SainiAditya1
force-pushed
the
fixdockerfile
branch
from
b7df39d to
761583d
Compare
Signed-off-by: Aditya Saini <adityasaini10012001@outlook.com>
SainiAditya1
force-pushed
the
fixdockerfile
branch
from
761583d to
d5526ad
Compare
|
@TorstenDittmann , Please Review this. |
It will still not work like this due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Combined corepack enable, pnpm install, and pnpm run build commands into a single RUN instruction.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Yes