Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix design issues for topics modal #837

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Feb 21, 2024

What does this PR do?

  • fix total on topics page
  • move topics modal description closer to header
  • reduce space before pagination in topics modal
  • add dividers between topics in topics modal

Test Plan

Manual

image

Related PRs and Issues

Parent:

  • TBD

Have you read the Contributing Guidelines on issues?

Yes

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 0:30am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 0:30am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 0:30am

@TorstenDittmann TorstenDittmann merged commit 83c35aa into chore-update-sdk Feb 21, 2024
4 of 5 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-messaging-topics-modal branch February 21, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants