Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add message provider links #777

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

wess
Copy link
Contributor

@wess wess commented Feb 7, 2024

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 2:55pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 2:55pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 2:55pm

@TorstenDittmann TorstenDittmann merged commit 921c073 into 1.5.x Feb 8, 2024
4 of 5 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-add-message-provider-links branch February 8, 2024 08:21
@@ -20,6 +20,7 @@ type ProvidersMap = {
[key in Providers]?: {
imageIcon: string;
title: string;
link: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wess, how come the link was added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it, wasn't sure if we would need to reference it anywhere else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it. thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants