Fix fcm credentials #742
Merged
Fix fcm credentials #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abnegate
requested review from
stnguyen90 and
TorstenDittmann
and removed request for
stnguyen90
stnguyen90
reviewed
Jan 26, 2024
There was a problem hiding this comment.
I tested an upload but got the following error:
appwrite | [Error] Timestamp: 2024-01-26T17:36:16+00:00
appwrite | [Error] Method: POST
appwrite | [Error] URL: /v1/messaging/providers/fcm
appwrite | [Error] Type: TypeError
appwrite | [Error] Message: {closure}(): Argument #3 ($serviceAccountJSON) must be of type ?array, string given, called in /usr/src/code/vendor/utopia-php/framework/src/App.php on line 531
appwrite | [Error] File: /usr/src/code/app/controllers/api/messaging.php
appwrite | [Error] Line: 619
so either the API needs to be updated or the console does.
@stnguyen90 This was fixed in the API 👍 |
I see. I found the related PR: appwrite/appwrite#7484. |
stnguyen90
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix FCM param
serverKey->serviceAccountJSONTest Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)