-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set project endpoint based on the region #1508
Open
christyjacob4
wants to merge
13
commits into
main
Choose a base branch
from
feat-support-multi-region
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e9adda3
feat: set project endpoint based on the region
christyjacob4 c6a011e
feat: set project endpoint based on the region
christyjacob4 c86d6aa
feat: linter
christyjacob4 b708507
feat: linter
christyjacob4 4159544
Merge branch 'main' of github.com:appwrite/console into feat-support-…
christyjacob4 2f744a8
feat: add constants for regions
christyjacob4 2c4af1f
feat: add constants for regions
christyjacob4 d02f97f
feat: linter
christyjacob4 88b6390
chore: update endpoint
christyjacob4 d667129
feat: update domains for staging
christyjacob4 63fa46f
Merge branch 'main' of github.com:appwrite/console into feat-support-…
christyjacob4 018a732
Merge branch 'main' of https://github.com/appwrite/console into feat-…
TorstenDittmann 08369e4
Merge branch 'main' of https://github.com/appwrite/console into feat-…
TorstenDittmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -24,12 +24,36 @@ import { | |||||||||||||||||||||||||||||||
import { Billing } from '../sdk/billing'; | ||||||||||||||||||||||||||||||||
import { Backups } from '../sdk/backups'; | ||||||||||||||||||||||||||||||||
import { Sources } from '$lib/sdk/sources'; | ||||||||||||||||||||||||||||||||
import { | ||||||||||||||||||||||||||||||||
REGION_FRA, | ||||||||||||||||||||||||||||||||
REGION_NYC, | ||||||||||||||||||||||||||||||||
REGION_SYD, | ||||||||||||||||||||||||||||||||
SUBDOMAIN_FRA, | ||||||||||||||||||||||||||||||||
SUBDOMAIN_NYC, | ||||||||||||||||||||||||||||||||
SUBDOMAIN_SYD | ||||||||||||||||||||||||||||||||
} from '$lib/constants'; | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
export function getApiEndpoint(): string { | ||||||||||||||||||||||||||||||||
export function getApiEndpoint(region?: string): string { | ||||||||||||||||||||||||||||||||
if (VARS.APPWRITE_ENDPOINT) return VARS.APPWRITE_ENDPOINT; | ||||||||||||||||||||||||||||||||
return globalThis?.location?.origin + '/v1'; | ||||||||||||||||||||||||||||||||
const protocol = globalThis?.location?.protocol; | ||||||||||||||||||||||||||||||||
const hostname = globalThis?.location?.hostname; | ||||||||||||||||||||||||||||||||
const subdomain = getSubdomain(region); | ||||||||||||||||||||||||||||||||
return `${protocol}//${subdomain}${hostname}/v1`; | ||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
const getSubdomain = (region?: string) => { | ||||||||||||||||||||||||||||||||
switch (region) { | ||||||||||||||||||||||||||||||||
case REGION_FRA: | ||||||||||||||||||||||||||||||||
return SUBDOMAIN_FRA; | ||||||||||||||||||||||||||||||||
case REGION_SYD: | ||||||||||||||||||||||||||||||||
return SUBDOMAIN_SYD; | ||||||||||||||||||||||||||||||||
case REGION_NYC: | ||||||||||||||||||||||||||||||||
return SUBDOMAIN_NYC; | ||||||||||||||||||||||||||||||||
default: | ||||||||||||||||||||||||||||||||
return ''; | ||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||
}; | ||||||||||||||||||||||||||||||||
Comment on lines
+44
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
we should probably avoid hardcoding regions for this in the console. |
||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
const endpoint = getApiEndpoint(); | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
const clientConsole = new Client(); | ||||||||||||||||||||||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need constants for that, its good enough to have them locally in the
sdk.ts