New Database Deletion Flow #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
heyCarla
reviewed
Aug 19, 2024
src/routes/console/project-[project]/databases/database-[database]/settings/+page.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Carla <cg.alexander@gmail.com>
…tABug/appwrite-console into database-deletion-new-flow
|
Todo: Add message that the database deletion will also delete its associated backups. |
ernstmul
reviewed
Oct 3, 2024
src/routes/(console)/project-[project]/databases/database-[database]/delete.svelte
Outdated
Show resolved
Hide resolved
Comment on lines
208
to
215
| :global(.max-height-dialog dialog) { | ||
| max-height: 650px !important; | ||
| } | ||
|
|
||
| :global(.no-inner-borders .table) { | ||
| box-shadow: unset !important; | ||
| border-radius: unset !important; | ||
| } |
There was a problem hiding this comment.
Are these !important's really needed?
src/routes/(console)/project-[project]/databases/database-[database]/+page.ts
Show resolved
Hide resolved
src/routes/(console)/project-[project]/databases/database-[database]/delete.svelte
Outdated
Show resolved
Hide resolved
src/routes/(console)/project-[project]/databases/database-[database]/delete.svelte
Show resolved
Hide resolved
src/routes/(console)/project-[project]/databases/database-[database]/delete.svelte
Outdated
Show resolved
Hide resolved
ernstmul
approved these changes
Nov 26, 2024
ernstmul
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)