Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloud Endpoints from Initialize SDKs Wizards #1189

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

ItzNotABug
Copy link
Member

What does this PR do?

Default endpoint is cloud, samples shouldn't need to add them.

Test Plan

Manual.

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Copy link

vercel bot commented Jul 12, 2024

@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@ItzNotABug
Copy link
Member Author

@TorstenDittmann, should we add .setEndpoint for self-hosted instances here, just like the .setSelfSigned logic?

@TorstenDittmann
Copy link
Contributor

@TorstenDittmann, should we add .setEndpoint for self-hosted instances here, just like the .setSelfSigned logic?

Yeah, lets add self-signed and endpoint to selfhosted instances 👍🏻

@ItzNotABug
Copy link
Member Author

@TorstenDittmann, should we add .setEndpoint for self-hosted instances here, just like the .setSelfSigned logic?

Yeah, lets add self-signed and endpoint to selfhosted instances 👍🏻

Done.

@ernstmul ernstmul merged commit d5915dd into appwrite:main Oct 9, 2024
2 checks passed
@ItzNotABug ItzNotABug deleted the remove-cloud-endpoints branch October 9, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants